Skip to content

feat: cp-7.52.0 Enable hardware accounts for transaction confirmations #17411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2025
Merged

feat: cp-7.52.0 Enable hardware accounts for transaction confirmations #17411

merged 6 commits into from
Jul 24, 2025
+26 −71

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jul 21, 2025

Description

This PR enables hardware accounts to make their transactions via redesigned transaction confirmations.

Changelog

CHANGELOG entry: Added hardware wallet support for redesigned transaction confirmations

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5035

Manual testing steps

Test any transaction with Ledger
Test any transaction with QR based wallet

Screenshots/Recordings

Before

After

Ledger scenario

Ledger.MP4

QR based wallet scenario

QR.based.MP4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner July 21, 2025 11:42
@OGPoyraz OGPoyraz added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E labels Jul 21, 2025
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 5d0d34a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4baa503f-48f9-485d-98eb-6a42c3944350

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 62e8d9c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83018cc7-b04b-4e6a-bc27-b26c21087c65

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0201ec8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ad3ef4e-3355-44d5-9c62-83389730230c

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 89ef315
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c0bcf9ad-c007-4139-8ed0-20e8575686c8

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vivek-consensys vivek-consensys added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a7d7bb4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50b21777-ac1c-4fe4-947b-7c21914b52d2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 22, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz OGPoyraz enabled auto-merge July 23, 2025 10:11
@OGPoyraz OGPoyraz changed the title feat: Enable hardware accounts for transaction confirmations feat: cp-7.52.0 Enable hardware accounts for transaction confirmations Jul 24, 2025
@OGPoyraz OGPoyraz mentioned this pull request Jul 24, 2025
Closed
@OGPoyraz OGPoyraz added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 06f2aef Jul 24, 2025
58 of 60 checks passed
@OGPoyraz OGPoyraz deleted the ogp/5035 branch July 24, 2025 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 24, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 7, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

11 similar comments
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 7, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 3, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OGPoyraz @metamaskbot @matthewwalsh0 @vivek-consensys