Skip to content

Conversation

@gauthierpetetin
Copy link
Contributor

Description

Release PR base branch is currently hardcoded to main which is not convenient, as it should be set to stable for Mobile.

This PR makes it possible to manually define the name of release PR base branch. It leverages changes introduced on github-tools repo in this PR.

We've already introduced and tested the same change on metamask-extension repo (see MetaMask/metamask-extension#35194 and MetaMask/metamask-extension#35197).

Changelog

CHANGELOG entry: non user-facing

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin self-assigned this Aug 20, 2025
@gauthierpetetin gauthierpetetin added No QA Needed Apply this label when your PR does not need any QA effort. team-extension-platform Extension Platform team No E2E Smoke Needed no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Aug 20, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit 8f29d2f Aug 22, 2025
96 of 97 checks passed
@gauthierpetetin gauthierpetetin deleted the release-pr-base-branch branch August 22, 2025 09:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.55.0 Issue or pull request that will be included in release 7.55.0 size-S team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants