Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Eigen header-only library #26

Merged
merged 3 commits into from
Sep 21, 2016
Merged

Added Eigen header-only library #26

merged 3 commits into from
Sep 21, 2016

Conversation

corporateshark
Copy link
Contributor

This fixes #12.

@jslee02 jslee02 mentioned this pull request Sep 20, 2016
Closed
18 tasks
ras0219-msft
ras0219-msft reviewed Sep 20, 2016
View reviewed changes
ports/eigen/portfile.cmake
file(COPY ${CURRENT_BUILDTREES_DIR}/src/eigen/COPYING.README DESTINATION ${CURRENT_PACKAGES_DIR}/share/eigen/COPYING.README)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/eigen/COPYING.README ${CURRENT_PACKAGES_DIR}/share/eigen/copyright)

message(${CURRENT_BUILDTREES_DIR})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripts should avoid printing extra information unless it's unique to this particular package (we can fix this during the merge).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it's fixed by the last commit (83f5e57).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, awesome, thanks 👍

traversaro
traversaro reviewed Sep 21, 2016
View reviewed changes
ports/eigen/CONTROL
@@ -0,0 +1,3 @@
Source: eigen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting for the EXAMPLES.md file :

Second, determine a suitable package name. This should be ASCII, lowercase, and recognizable to someone who knows the library's "human name". If the library is already packaged in another package manager, prefer that name.

Eigen is known as:

  • Eigen3 as CMake package (see FindEigen3.cmake and Eigen3Config.cmake distributed by the project).
  • libeigen3-dev in Debian-based systems.
  • eigen3 in FreeBSD [1]
  • eigen3 in MacPorts [2]
  • eigen in homebrew [3]
  • eigen3 in fedora [4]
  • eigen in Gentoo [5]
  • eigen3 in MINGW [6]

Given that (except for homebrew and gentoo's portage) the Eigen package is always called eigen3, it could make sense to call it eigen3 also in vcpkg?

[1] : https://svnweb.freebsd.org/ports/head/math/eigen3/
[2] : https://trac.macports.org/browser/trunk/dports/math/eigen3/Portfile
[3] : http://brewformulas.org/Eigen
[4] : http://rpms.famillecollet.com/rpmphp/zoom.php?rpm=eigen3
[5] : https://packages.gentoo.org/packages/dev-cpp/eigen
[6] : https://github.com/msys2/MINGW-packages/tree/44faea9dde7642988ed6e837d6a39d8effaea3f4/mingw-w64-eigen3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should definitely be renamed to eigen3! Great detective work.

@corporateshark corporateshark mentioned this pull request Sep 21, 2016
Closed
@ras0219-msft ras0219-msft merged commit 7f31015 into microsoft:master Sep 21, 2016
@ras0219-msft
Copy link
Contributor

Thanks!

@traversaro traversaro mentioned this pull request Oct 30, 2016
Closed
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@upsj
add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (microsoft#26)
84dfd2c
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@strega-nil
prepare for new release: 2021-04-15 (microsoft#61)
96ec678 
The following PRs are included:

* hopefully fix crash in constraints (microsoft#60)
* [vcpkg] allow --version to check the version (microsoft#50)
* Remove baseline warning (microsoft#27)
* [git] always pass autocrlf=false (microsoft#58)
* ignore QtCreator CMake project files (microsoft#54)
* ignore .DS_store files (microsoft#53)
* [vcpkg] x-add-version now also checks if the manifest file is properly formatted (microsoft#43)
* hopefully fix ci issue microsoft#16773 (microsoft#34)
* Add docs to set VCPKG_ROOT to run tests (microsoft#45)
* [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (microsoft#44)
* add clang-format version to format-cxxcode (microsoft#41)
* [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (microsoft#40)
* [supports] Add `native` identifier expression and x-check-support command (microsoft#29)
* [metrics] Split reporting of installs into name:triplet (microsoft#39)
* [vcpkg] Improve error when accessing missing feature (microsoft#38)
* [vcpkg] Allow shallow git registries (microsoft#37)
* Disable git autocrlf when archiving tree (microsoft#36)
* Use only named packages from extra registries (microsoft#35)
* [registries] add metrics (microsoft#30)
* Add vcpkg policy cmake helper port support (microsoft#17)
* [osx] add support for rosetta (microsoft#23)
* don't build tls12-download unless it's needed (microsoft#33)
* Add new telemetry points for versioning (microsoft#21)
* add cmake_minimum_required to vcpkg_tags (microsoft#25)
* [x-add-versions] Perform atomic replacement of versioning files (microsoft#28)
* [tools] support gsutil (microsoft#19)
* add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (microsoft#26)
* Add finite timeout on CURL metrics endpoint. (microsoft#22)
* fix UB in make_error_code(utf8_errc) (microsoft#18)
Be-ing added a commit to Be-ing/vcpkg that referenced this pull request Oct 19, 2021
@Be-ing
Merge pull request microsoft#26 from Be-ing/osx_triplets
1b70fe2 
add custom macOS triplet for Qt6
SchaichAlonso pushed a commit to PurpleFlowerGarden/vcpkg that referenced this pull request Mar 31, 2022
@SchaichAlonso
[cairomm] update to 1.16.1 (microsoft#23903)
ca2eb54 
Cairo:
* Surface::Type: Deprecate WIN32, add WIN32_SURFACE
  (Kjell Ahlstedt) Issue microsoft#26, merge request !14

Build:
* cairommconfig.h.*: Don't dllimport on MinGW
  (Chun-wei Fan) Merge reqest !16
  (Chun-wei Fan) Issue gtkmm#90 (Lukas K.)
* Meson build: Make it possible to use cairomm as a subproject
  (Kjell Ahlstedt)
* Meson build: No implicit_include_directories
  (Kjell Ahlstedt)
* MSVC build: exception.h: Export Cairo::logic_error selectively
  (Chun-wei Fan) Merge request !17
strega-nil-ms pushed a commit that referenced this pull request Apr 5, 2022
@SchaichAlonso
[cairomm] update to 1.16.1 (#23904)
3f7655c 
* [cairomm] update to 1.16.1 (#23903)

Cairo:
* Surface::Type: Deprecate WIN32, add WIN32_SURFACE
  (Kjell Ahlstedt) Issue #26, merge request !14

Build:
* cairommconfig.h.*: Don't dllimport on MinGW
  (Chun-wei Fan) Merge reqest !16
  (Chun-wei Fan) Issue gtkmm#90 (Lukas K.)
* Meson build: Make it possible to use cairomm as a subproject
  (Kjell Ahlstedt)
* Meson build: No implicit_include_directories
  (Kjell Ahlstedt)
* MSVC build: exception.h: Export Cairo::logic_error selectively
  (Chun-wei Fan) Merge request !17

* [cairomm] remove patch (#23903)

The WIN32 constant has been renamed to WIN32_SURFACE , and the
WIN32 -> WIN32_SURFACE alias is only provided for non-win32
sytems, therefore our previous patch is no longer needed.

* [cairomm] Support MSVC2022 (#23903)

Manually add ed1ce9a630b375b0f43435e34fbe690eb8276178 from upstream,
which prevents MSVC 2022 toolchains from being overridden by the
meson port file, resulting in corrupted binarycache metadata

* [cairomm] update version registries (#23903)

* [cairomm] add license (#23903)

* [cairomm] regenerate license registry (#23903)

Co-authored-by: Schaich <alonso.schaich@sodgeit.de>
dempo93 pushed a commit to dempo93/vcpkg that referenced this pull request Aug 23, 2022
@miccol
Merge pull request microsoft#26 from facontidavide/dev_logging
3ede1ad 
Logging++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft left review comments

@jslee02 jslee02 jslee02 left review comments

@traversaro traversaro traversaro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Eigen
4 participants
@corporateshark @ras0219-msft @traversaro @jslee02