Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-24570] Exclude dataset symlinks with no inputs/outputs #189

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 18, 2025

Change Summary

Before - dataset symlinks are always included into lineage graph:
Снимок экрана_20250318_142049-1

After - dataset symlinks are included only of they have some input or output:
Снимок экрана_20250318_141958-1

This reduces visual noise.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Sorry, something went wrong.

@dolfinus dolfinus self-assigned this Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (a25bcae) to head (1212264).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #189      +/-   ##
===========================================
+ Coverage    91.87%   91.90%   +0.02%     
===========================================
  Files          197      197              
  Lines         4872     4889      +17     
  Branches       338      342       +4     
===========================================
+ Hits          4476     4493      +17     
  Misses         327      327              
  Partials        69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Verified

This commit was signed with the committer’s verified signature.
dolfinus Maxim Martynov
@dolfinus dolfinus force-pushed the improvement/DOP-24570 branch from f1d5052 to 1212264 Compare March 18, 2025 11:19
@dolfinus dolfinus marked this pull request as ready for review March 18, 2025 11:22
@dolfinus dolfinus merged commit 89d8ff8 into develop Mar 18, 2025
13 checks passed
@dolfinus dolfinus deleted the improvement/DOP-24570 branch March 18, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants