Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-24570] Add tests for lineage excluding symlinks with no IO #193

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 21, 2025

Change Summary

#189 was landed without any tests, fixing that.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Mar 21, 2025
@dolfinus dolfinus self-assigned this Mar 21, 2025
@dolfinus dolfinus force-pushed the feature/DOP-24570 branch from 8b6dd0a to 2002552 Compare March 21, 2025 15:18
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (8dc8bda) to head (2c8c592).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #193   +/-   ##
========================================
  Coverage    91.88%   91.88%           
========================================
  Files          199      199           
  Lines         4954     4954           
  Branches       343      343           
========================================
  Hits          4552     4552           
  Misses         334      334           
  Partials        68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus requested a review from TiGrib March 21, 2025 15:21
@dolfinus dolfinus marked this pull request as ready for review March 21, 2025 15:21
@dolfinus dolfinus force-pushed the feature/DOP-24570 branch from 2002552 to 2c8c592 Compare March 24, 2025 10:49
@dolfinus dolfinus enabled auto-merge (rebase) March 24, 2025 10:49
@dolfinus dolfinus merged commit 4cdc96e into develop Mar 24, 2025
11 checks passed
@dolfinus dolfinus deleted the feature/DOP-24570 branch March 24, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants