Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Issue NOAA-EMC/GSI#152. #153

Merged
merged 1 commit into from
May 3, 2021
Merged

GitHub Issue NOAA-EMC/GSI#152. #153

merged 1 commit into from
May 3, 2021

Conversation

lbi2018
Copy link
Contributor

@lbi2018 lbi2018 commented Apr 29, 2021

Update of modulefile.ProdGSI.wcoss_c and get_gefs_for_regional.f90 bug fixes.

@MichaelLueken MichaelLueken linked an issue Apr 29, 2021 that may be closed by this pull request
update of modulefile.ProdGSI.wcoss_c and get_gefs_for_regional.f90 bug fixes #152
Closed
TingLei-daprediction
TingLei-daprediction approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@TingLei-daprediction TingLei-daprediction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me! Thanks.

MichaelLueken
MichaelLueken reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Li,

I have completed my review of the changes in this PR. The regression tests were run (both standard and debug) and all successfully passed. It was noted, that while compiling in debug mode, one variable was flagged as unused. When you replaced mype_out with 0, you will need to remove the declaration of mype_out on line 119 of get_gefs_for_regional.f90. Once this is done, I will be able to get this work out to the review committee, with a due date of Monday. If you have any questions, please let me know.

Mike

@lbi2018
Copy link
Contributor Author

lbi2018 commented Apr 30, 2021

Hi Li,

I have completed my review of the changes in this PR. The regression tests were run (both standard and debug) and all successfully passed. It was noted, that while compiling in debug mode, one variable was flagged as unused. When you replaced mype_out with 0, you will need to remove the declaration of mype_out on line 119 of get_gefs_for_regional.f90. Once this is done, I will be able to get this work out to the review committee, with a due date of Monday. If you have any questions, please let me know.

Mike

Hi Mike,

I removed line 119.

Thanks,
-Li

@MichaelLueken
Copy link
Contributor

The due date has past with no feedback, so final approval will now be given and these changes will be merged to the NOAA-EMC/GSI master.

@MichaelLueken MichaelLueken merged commit dcb735a into NOAA-EMC:master May 3, 2021
AndrewEichmann-NOAA added a commit to AndrewEichmann-NOAA/GSI that referenced this pull request Jun 21, 2021
@AndrewEichmann-NOAA
Squashed commit of the following:
fc4b154 
commit 67705a1
Merge: 5e53aaf 18afa96
Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com>
Date:   Fri Jun 11 10:55:08 2021 -0400

    Merge branch 'NOAA-EMC:master' into master

commit 18afa96
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Thu Jun 10 11:57:29 2021 +0000

    master: Updated fix/rev2 use flags for CrIS NPP due to LW band anomalies (global_satinfo.txt and added gfsv16_historical/global_satinfo.txt.2021052118

commit 51a6564
Merge: 820ee80 d199ed5
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu Jun 10 07:48:55 2021 -0400

    Merge pull request NOAA-EMC#169 from RussTreadon-NOAA/master

    GitHub Issue NOAA-EMC#120. Merge GFS v16.1.1 DA changes into master

commit d199ed5
Author: russ.treadon <Russ.Treadon@noaa.gov>
Date:   Thu May 27 19:08:39 2021 +0000

    GitHub Issue NOAA-EMC#120. merge GFS v16.1.1 DA changes into master

commit 820ee80
Merge: 6585234 86d4071
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 28 11:34:46 2021 -0400

    Merge pull request NOAA-EMC#155 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_src

    GitHub Issue NOAA-EMC#118.  EFSOI additions to util/EFSOI-Utilities/src directory.

commit 86d4071
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Fri May 28 15:31:10 2021 +0000

    GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific util source code.

commit 6585234
Merge: 6cec754 efaa7cf
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 28 11:20:54 2021 -0400

    Merge pull request NOAA-EMC#166 from comgsi/prMaster

    GitHub Issue NOAA-EMC#167.  Change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly.

commit efaa7cf
Author: Guoqing.Ge <guoqing.ge@noaa.gov>
Date:   Wed May 26 15:51:51 2021 -0600

    change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly

commit 5e53aaf
Merge: e54683c 6cec754
Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com>
Date:   Mon May 24 14:34:33 2021 -0400

    Merge branch 'NOAA-EMC:master' into master

commit 6cec754
Merge: 6a6ac4e 3cc26ec
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 21 13:48:26 2021 -0400

    Merge pull request NOAA-EMC#147 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_scripts

    GitHub Issue NOAA-EMC#118.  EFSOI additions to util/EFSOI-Utilities/scripts directory.

commit 6a6ac4e
Merge: 1162d92 62c884c
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 20 11:03:36 2021 -0400

    Merge pull request NOAA-EMC#146 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_jobs

    GitHub Issue NOAA-EMC#118.  EFSOI additions to jobs directory for issue.

commit 1162d92
Merge: 6e38b98 77a729e
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Wed May 19 11:02:40 2021 -0400

    Merge pull request NOAA-EMC#157 from comgsi/tmpdtc

    GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure.

commit 6e38b98
Merge: b511ba0 00eb5da
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Wed May 19 07:27:08 2021 -0400

    Merge pull request NOAA-EMC#164 from EdwardSafford-NOAA/master

    GitHub Issue NOAA-EMC#160.  Correct data file location problem.

commit 00eb5da
Author: Edward.Safford <edward.safford@noaa.gov>
Date:   Tue May 18 16:31:34 2021 +0000

    GitHub Issue NOAA-EMC#160.  Correct data file location problem.

commit b511ba0
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Tue May 18 14:38:15 2021 +0000

    GitHub Issue NOAA-EMC#126. Update global_convinfo.txt and prepobs_errtable.global for high resolution Raob data.

commit 66db434
Merge: dcb735a 23ec8ef
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue May 18 10:06:16 2021 -0400

    Merge pull request NOAA-EMC#149 from jderber-NOAA/master

    GitHub Issue NOAA-EMC#126.  Add use of high resolution Raob data.

commit 77a729e
Author: Guoqing.Ge <guoqing.ge@noaa.gov>
Date:   Fri May 14 11:15:32 2021 -0600

    GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure.

commit e54683c
Merge: f69c3c8 b31b851
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu May 13 14:39:23 2021 +0000

    Merge branch 'master' of github.com:AndrewEichmann-NOAA/GSI

commit f69c3c8
Merge: 1dc5f83 dcb735a
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu May 13 14:37:10 2021 +0000

    Merge branch 'master' of github.com:NOAA-EMC/GSI

commit 3cc26ec
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu May 13 14:28:03 2021 +0000

    GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI additions to util/EFSOI-Utilities/scripts directory.

commit 62c884c
Author: Michael Lueken <michael.lueken@noaa.gov>
Date:   Tue May 11 14:31:14 2021 +0000

    GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific additions to jobs.

commit 23ec8ef
Author: john.derber <John.Derber@noaa.gov>
Date:   Mon Apr 26 19:29:18 2021 +0000

    GitHub Issue NOAA-EMC#126.  Add use of high resolution Raob data.

commit dcb735a
Merge: c502c92 7939d47
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon May 3 12:57:43 2021 -0400

    Merge pull request NOAA-EMC#153 from lbi2018/master

    GitHub Issue NOAA-EMC#152.

commit b31b851
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Fri Apr 30 15:34:59 2021 +0000

    Should not have gone into master
    Revert "EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118"

    This reverts commit c9b8221.

commit c9b8221
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Fri Apr 30 15:30:59 2021 +0000

    EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118

commit 7939d47
Author: Li.Bi@noaa.gov <Li.Bi@noaa.gov>
Date:   Wed Apr 28 13:15:30 2021 +0000

    GitHub Issue NOAA-EMC#152. Update of modulefile.ProdGSI.wcoss_c and get_gefs_for_regional.f90 bug fixes.

commit c502c92
Merge: 39ed5fa 5d77565
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon Apr 26 10:22:12 2021 -0400

    Merge pull request NOAA-EMC#151 from EdwardSafford-NOAA/master

    GitHub Issue NOAA-EMC#150.  Correct OznMon read diag issue.

commit 5d77565
Author: edward.safford <edward.safford@noaa.gov>
Date:   Fri Apr 23 19:42:54 2021 +0000

    GitHub Issue NOAA-EMC#150.  Correct OznMon read diag issue.

commit 39ed5fa
Merge: 02d5ce6 1e6fd61
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue Apr 13 09:37:05 2021 -0400

    Merge pull request NOAA-EMC#144 from EdwardSafford-NOAA/master

    GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes.

commit 1e6fd61
Author: Edward.Safford <edward.safford@noaa.gov>
Date:   Fri Apr 9 14:40:01 2021 +0000

    GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes.

commit 1dc5f83
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu Apr 8 21:15:51 2021 +0000

    removing EFSOI source files until they are merged into GSI master upstream
AndrewEichmann-NOAA added a commit to AndrewEichmann-NOAA/GSI that referenced this pull request Jun 21, 2021
@AndrewEichmann-NOAA
Squashed commit of the following:
ea93dcd 
commit 67705a1
Merge: 5e53aaf 18afa96
Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com>
Date:   Fri Jun 11 10:55:08 2021 -0400

    Merge branch 'NOAA-EMC:master' into master

commit 18afa96
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Thu Jun 10 11:57:29 2021 +0000

    master: Updated fix/rev2 use flags for CrIS NPP due to LW band anomalies (global_satinfo.txt and added gfsv16_historical/global_satinfo.txt.2021052118

commit 51a6564
Merge: 820ee80 d199ed5
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu Jun 10 07:48:55 2021 -0400

    Merge pull request NOAA-EMC#169 from RussTreadon-NOAA/master

    GitHub Issue NOAA-EMC#120. Merge GFS v16.1.1 DA changes into master

commit d199ed5
Author: russ.treadon <Russ.Treadon@noaa.gov>
Date:   Thu May 27 19:08:39 2021 +0000

    GitHub Issue NOAA-EMC#120. merge GFS v16.1.1 DA changes into master

commit 820ee80
Merge: 6585234 86d4071
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 28 11:34:46 2021 -0400

    Merge pull request NOAA-EMC#155 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_src

    GitHub Issue NOAA-EMC#118.  EFSOI additions to util/EFSOI-Utilities/src directory.

commit 86d4071
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Fri May 28 15:31:10 2021 +0000

    GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific util source code.

commit 6585234
Merge: 6cec754 efaa7cf
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 28 11:20:54 2021 -0400

    Merge pull request NOAA-EMC#166 from comgsi/prMaster

    GitHub Issue NOAA-EMC#167.  Change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly.

commit efaa7cf
Author: Guoqing.Ge <guoqing.ge@noaa.gov>
Date:   Wed May 26 15:51:51 2021 -0600

    change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly

commit 5e53aaf
Merge: e54683c 6cec754
Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com>
Date:   Mon May 24 14:34:33 2021 -0400

    Merge branch 'NOAA-EMC:master' into master

commit 6cec754
Merge: 6a6ac4e 3cc26ec
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 21 13:48:26 2021 -0400

    Merge pull request NOAA-EMC#147 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_scripts

    GitHub Issue NOAA-EMC#118.  EFSOI additions to util/EFSOI-Utilities/scripts directory.

commit 6a6ac4e
Merge: 1162d92 62c884c
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 20 11:03:36 2021 -0400

    Merge pull request NOAA-EMC#146 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_jobs

    GitHub Issue NOAA-EMC#118.  EFSOI additions to jobs directory for issue.

commit 1162d92
Merge: 6e38b98 77a729e
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Wed May 19 11:02:40 2021 -0400

    Merge pull request NOAA-EMC#157 from comgsi/tmpdtc

    GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure.

commit 6e38b98
Merge: b511ba0 00eb5da
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Wed May 19 07:27:08 2021 -0400

    Merge pull request NOAA-EMC#164 from EdwardSafford-NOAA/master

    GitHub Issue NOAA-EMC#160.  Correct data file location problem.

commit 00eb5da
Author: Edward.Safford <edward.safford@noaa.gov>
Date:   Tue May 18 16:31:34 2021 +0000

    GitHub Issue NOAA-EMC#160.  Correct data file location problem.

commit b511ba0
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Tue May 18 14:38:15 2021 +0000

    GitHub Issue NOAA-EMC#126. Update global_convinfo.txt and prepobs_errtable.global for high resolution Raob data.

commit 66db434
Merge: dcb735a 23ec8ef
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue May 18 10:06:16 2021 -0400

    Merge pull request NOAA-EMC#149 from jderber-NOAA/master

    GitHub Issue NOAA-EMC#126.  Add use of high resolution Raob data.

commit 77a729e
Author: Guoqing.Ge <guoqing.ge@noaa.gov>
Date:   Fri May 14 11:15:32 2021 -0600

    GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure.

commit e54683c
Merge: f69c3c8 b31b851
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu May 13 14:39:23 2021 +0000

    Merge branch 'master' of github.com:AndrewEichmann-NOAA/GSI

commit f69c3c8
Merge: 1dc5f83 dcb735a
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu May 13 14:37:10 2021 +0000

    Merge branch 'master' of github.com:NOAA-EMC/GSI

commit 3cc26ec
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu May 13 14:28:03 2021 +0000

    GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI additions to util/EFSOI-Utilities/scripts directory.

commit 62c884c
Author: Michael Lueken <michael.lueken@noaa.gov>
Date:   Tue May 11 14:31:14 2021 +0000

    GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific additions to jobs.

commit 23ec8ef
Author: john.derber <John.Derber@noaa.gov>
Date:   Mon Apr 26 19:29:18 2021 +0000

    GitHub Issue NOAA-EMC#126.  Add use of high resolution Raob data.

commit dcb735a
Merge: c502c92 7939d47
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon May 3 12:57:43 2021 -0400

    Merge pull request NOAA-EMC#153 from lbi2018/master

    GitHub Issue NOAA-EMC#152.

commit b31b851
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Fri Apr 30 15:34:59 2021 +0000

    Should not have gone into master
    Revert "EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118"

    This reverts commit c9b8221.

commit c9b8221
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Fri Apr 30 15:30:59 2021 +0000

    EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118

commit 7939d47
Author: Li.Bi@noaa.gov <Li.Bi@noaa.gov>
Date:   Wed Apr 28 13:15:30 2021 +0000

    GitHub Issue NOAA-EMC#152. Update of modulefile.ProdGSI.wcoss_c and get_gefs_for_regional.f90 bug fixes.

commit c502c92
Merge: 39ed5fa 5d77565
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon Apr 26 10:22:12 2021 -0400

    Merge pull request NOAA-EMC#151 from EdwardSafford-NOAA/master

    GitHub Issue NOAA-EMC#150.  Correct OznMon read diag issue.

commit 5d77565
Author: edward.safford <edward.safford@noaa.gov>
Date:   Fri Apr 23 19:42:54 2021 +0000

    GitHub Issue NOAA-EMC#150.  Correct OznMon read diag issue.

commit 39ed5fa
Merge: 02d5ce6 1e6fd61
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue Apr 13 09:37:05 2021 -0400

    Merge pull request NOAA-EMC#144 from EdwardSafford-NOAA/master

    GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes.

commit 1e6fd61
Author: Edward.Safford <edward.safford@noaa.gov>
Date:   Fri Apr 9 14:40:01 2021 +0000

    GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes.

commit 1dc5f83
Author: andrew.eichmann <andrew.eichmann@noaa.gov>
Date:   Thu Apr 8 21:15:51 2021 +0000

    removing EFSOI source files until they are merged into GSI master upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelLueken MichaelLueken MichaelLueken left review comments

@TingLei-daprediction TingLei-daprediction TingLei-daprediction approved these changes

@TingLei-NOAA TingLei-NOAA Awaiting requested review from TingLei-NOAA

@dtkleist dtkleist Awaiting requested review from dtkleist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update of modulefile.ProdGSI.wcoss_c and get_gefs_for_regional.f90 bug fixes
3 participants
@lbi2018 @MichaelLueken @TingLei-daprediction