GitHub Issue NOAA-EMC/GSI#120. merge GFS v16.1.1 DA changes into master #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I have completed my review of these changes. There are a handful of minor issues with src/gsi/setupbend.f90 (replacing .le. and .gt. with symbols, adding proper precision to real values, and addressing an issue with indentation) and src/enkf/gridio_gfs.f90 (removal of commented out debug prints). The regression tests were ran and
- global_C96_fv3aerorad_regression_results.txt
- global_fv3_4denvar_C192_regression_results.txt
- global_fv3_4denvar_T126_regression_results.txt
Failed due to reproducibility between NOAA-EMC/GSI master and the changes in this PR. I didn't see any reproducibility issues being indicated in issue #120. Do you see similar reproducibility failures?
The code was compiled and ran in debug mode and the code compiled without issue and the debug tests ran through to completion.
Please address the issues in the two files and double check to see if you are seeing reproducibility issues for the three configurations.
Thanks,
Mike
|
Thanks, Mike, for the quick review. Let me work through the corrections.
I will inform the developers who added these changes so that they are aware
of these coding standards. I have not yet run the full suite of
regression tests. Let me do so.
When all changes are made in my forked working copy of the master, I need
to be careful and ensure that the resulting commit only appears as 1 commit
in the PR. The GSI wiki contains the section "How to rebase the master
into your active PR". This applies to bringing updates from the
authoritative master into a developer PR. Do we have comparable
instructions for how to commit reviewer requested revisions into an active
PR?
…On Fri, May 28, 2021 at 11:36 AM MichaelLueken-NOAA < ***@***.***> wrote:
***@***.**** commented on this pull request.
Hi @RussTreadon-NOAA <https://github.com/RussTreadon-NOAA>,
I have completed my review of these changes. There are a handful of minor
issues with src/gsi/setupbend.f90 (replacing .le. and .gt. with symbols,
adding proper precision to real values, and addressing an issue with
indentation) and src/enkf/gridio_gfs.f90 (removal of commented out debug
prints). The regression tests were ran and
- global_C96_fv3aerorad_regression_results.txt
- global_fv3_4denvar_C192_regression_results.txt
- global_fv3_4denvar_T126_regression_results.txt
Failed due to reproducibility between NOAA-EMC/GSI master and the changes
in this PR. I didn't see any reproducibility issues being indicated in
issue #120 <#120>. Do you see
similar reproducibility failures?
The code was compiled and ran in debug mode and the code compiled without
issue and the debug tests ran through to completion.
Please address the issues in the two files and double check to see if you
are seeing reproducibility issues for the three configurations.
Thanks,
Mike
------------------------------
In src/enkf/gridio_gfs.f90
<#169 (comment)>:
> delzb=(rd/grav)*reshape(tv_bg(:,:,ki),(/nlons*nlats/))
- delzb=delzb*log((100_r_kind*ak(krev)+bk(krev)*values_1d)/(100_r_kind*ak(krev+1)+bk(krev+1)*values_1d))
- ug3d(:,:,ki)=values_3d(:,:,ki) + reshape(delzb-ug,(/nlons,nlats/))
+ delzb=delzb*log((100_r_kind*ak(krev+1)+bk(krev+1)*values_1d)/(100_r_kind*ak(krev)+bk(krev)*values_1d))
+ !print *,'writegriddata_pnc: min/max delzb',k,minval(delzb),maxval(delzb)
Please remove commented out debug print on line 1527.
------------------------------
In src/enkf/gridio_gfs.f90
<#169 (comment)>:
> @@ -2475,8 +2484,10 @@ subroutine writegriddata(nanal1,nanal2,vars3d,vars2d,n3d,n2d,levels,ndim,grdin,n
if (hasfield) then
call nemsio_readrecv(gfilein,'pres','sfc',1,nems_wrk2,iret=iret)
delzb=(rd/grav)*nems_wrk
- ! ps in Pa here, need to multiply ak by 100.
- delzb=delzb*log((100_r_kind*ak(k)+bk(k)*nems_wrk2)/(100_r_kind*ak(k+1)+bk(k+1)*nems_wrk2))
+ ! ps in Pa here, need to multiply ak by 100. k is bottom to top,
+ ! calculate delzb so it is negative.
+ delzb=delzb*log((100_r_kind*ak(k+1)+bk(k+1)*nems_wrk2)/(100_r_kind*ak(k)+bk(k)*nems_wrk2))
+ !print *,'writegriddata nemsio: min/max delzb',k,minval(delzb),maxval(delzb)
Please remove commented out debug print on line 2490.
------------------------------
In src/enkf/gridio_gfs.f90
<#169 (comment)>:
> ! ug is hydrostatic analysis delz inferred from analysis ps,Tv
! delzb is hydrostatic background delz inferred from background ps,Tv
- delzb=(rd/grav)*reshape(tv_bg(:,:,nlevs-k+1),(/nlons*nlats/))
- delzb=delzb*log((100_r_kind*ak(k)+bk(k)*values_1d)/(100_r_kind*ak(k+1)+bk(k+1)*values_1d))
- ug3d(:,:,nlevs-k+1)=values_3d(:,:,nlevs-k+1) +&
- reshape(delzb-ug,(/nlons,nlats/))
+ ! calculate so it is negative
+ delzb=(rd/grav)*reshape(tv_bg(:,:,k),(/nlons*nlats/))
+ delzb=delzb*log((100_r_kind*ak(krev+1)+bk(krev+1)*values_1d)/(100_r_kind*ak(krev)+bk(krev)*values_1d))
+ !print *,'writegriddata netcdf: min/max delzb',k,minval(delzb),maxval(delzb)
Please remove commented out debug print on line 2903.
------------------------------
In src/enkf/gridio_gfs.f90
<#169 (comment)>:
> ! ug is hydrostatic analysis delz inferred from analysis ps,Tv
! delzb is hydrostatic background delz inferred from background ps,Tv
delzb=(rd/grav)*reshape(tv(:,:,k),(/nlons*nlats/))
- delzb=delzb*log((100_r_kind*ak(krev)+bk(krev)*psges)/(100_r_kind*ak(krev+1)+bk(krev+1)*psges))
- inc3d(:,:,k)=reshape(delzb-ug,(/nlons,nlats/))
+ delzb=delzb*log((100_r_kind*ak(krev+1)+bk(krev+1)*psges)/(100_r_kind*ak(krev)+bk(krev)*psges))
+ !print *,'writeincrement: min/max delzb',k,minval(delzb),maxval(delzb)
Please remove commented out debug print on line 3603.
------------------------------
In src/enkf/gridio_gfs.f90
<#169 (comment)>:
> delzb=(rd/grav)*reshape(tv(:,:,ki),(/nlons*nlats/))
- delzb=delzb*log((100_r_kind*ak(krev)+bk(krev)*psges)/(100_r_kind*ak(krev+1)+bk(krev+1)*psges))
- inc3d(:,:,ki)=reshape(delzb-ug,(/nlons,nlats/))
+ delzb=delzb*log((100_r_kind*ak(krev+1)+bk(krev+1)*psges)/(100_r_kind*ak(krev)+bk(krev)*psges))
+ !print *,'writeincrement_pnc: min/max delzb',k,minval(delzb),maxval(delzb)
Please remove commented out debug print on line 4051.
------------------------------
In src/gsi/setupbend.f90
<#169 (comment)>:
> -! get pressure (in mb), temperature and moisture at obs location
- call tintrp31(ges_lnprsi(:,:,1:nsig,:),dpressure,dlat,dlon,hob,&
+ if (alt <= six) then
+ if (top_layer_SR >= 1) then ! SR exists for at least one layer. Check if obs is inside
+ if (tpdpres(i)==ref_rad(top_layer_SR+1)) then !obs inside model SR layer
+ qcfail(i)=.true.
+ elseif (tpdpres(i) < ref_rad(top_layer_SR+1)) then !obs below model close-to-SR layer
+ qcfail(i)=.true.
+ elseif (tpdpres(i) >= ref_rad(top_layer_SR+1) .and. tpdpres(i) <= ref_rad(top_layer_SR+2)) then !source too close
+ qcfail(i)=.true.
+ else !above
+ endif
+ endif
+
+! check for SR in obs, will be updated in genstats.
+ if ( data(igps,i) >= 0.03 .and. qc_layer_SR) then
Please add proper precision to real value 0.03 on line 596.
------------------------------
In src/gsi/setupbend.f90
<#169 (comment)>:
> + repe_gps=0.19032_r_kind+0.287535_r_kind*alt-0.00260813_r_kind*alt**2
+ else
+ repe_gps=-3.20978_r_kind+1.26964_r_kind*alt-0.0622538_r_kind*alt**2
+ endif
+ else
+ if(alt>r18) then
+ repe_gps=-1.87788_r_kind+0.354718_r_kind*alt-0.00313189_r_kind*alt**2
+ else
+ repe_gps=-2.41024_r_kind+0.806594_r_kind*alt-0.027257_r_kind*alt**2
+ endif
+ endif
+ else
+! CDAAC-type processing
+ if ((data(isatid,i) > 749).and.(data(isatid,i) < 756)) then
+ if ((data(ilate,i)> r40).or.(data(ilate,i)< -r40)) then
+ if (alt.le.8.0_r_kind) then
Please replace .le. with <= on line 647.
------------------------------
In src/gsi/setupbend.f90
<#169 (comment)>:
> + repe_gps=-3.20978_r_kind+1.26964_r_kind*alt-0.0622538_r_kind*alt**2
+ endif
+ else
+ if(alt>r18) then
+ repe_gps=-1.87788_r_kind+0.354718_r_kind*alt-0.00313189_r_kind*alt**2
+ else
+ repe_gps=-2.41024_r_kind+0.806594_r_kind*alt-0.027257_r_kind*alt**2
+ endif
+ endif
+ else
+! CDAAC-type processing
+ if ((data(isatid,i) > 749).and.(data(isatid,i) < 756)) then
+ if ((data(ilate,i)> r40).or.(data(ilate,i)< -r40)) then
+ if (alt.le.8.0_r_kind) then
+ repe_gps=-1.0304261_r_kind+0.3203316_r_kind*alt+0.0141337_r_kind*alt**2
+ elseif (alt.gt.8.0_r_kind.and.alt.le.r12) then
Please replace .gt. with > and .le. with <= on line 649.
------------------------------
In src/gsi/setupbend.f90
<#169 (comment)>:
> + repe_gps=-2.41024_r_kind+0.806594_r_kind*alt-0.027257_r_kind*alt**2
+ endif
+ endif
+ else
+! CDAAC-type processing
+ if ((data(isatid,i) > 749).and.(data(isatid,i) < 756)) then
+ if ((data(ilate,i)> r40).or.(data(ilate,i)< -r40)) then
+ if (alt.le.8.0_r_kind) then
+ repe_gps=-1.0304261_r_kind+0.3203316_r_kind*alt+0.0141337_r_kind*alt**2
+ elseif (alt.gt.8.0_r_kind.and.alt.le.r12) then
+ repe_gps=2.1750271_r_kind+0.0431177_r_kind*alt-0.0008567_r_kind*alt**2
+ else
+ repe_gps=-0.3447429_r_kind+0.2829981_r_kind*alt-0.0028545_r_kind*alt**2
+ endif
+ else
+ if (alt.le.4.0_r_kind) then
Please replace .le. with <= on line 655.
------------------------------
In src/gsi/setupbend.f90
<#169 (comment)>:
> + endif
+ else
+! CDAAC-type processing
+ if ((data(isatid,i) > 749).and.(data(isatid,i) < 756)) then
+ if ((data(ilate,i)> r40).or.(data(ilate,i)< -r40)) then
+ if (alt.le.8.0_r_kind) then
+ repe_gps=-1.0304261_r_kind+0.3203316_r_kind*alt+0.0141337_r_kind*alt**2
+ elseif (alt.gt.8.0_r_kind.and.alt.le.r12) then
+ repe_gps=2.1750271_r_kind+0.0431177_r_kind*alt-0.0008567_r_kind*alt**2
+ else
+ repe_gps=-0.3447429_r_kind+0.2829981_r_kind*alt-0.0028545_r_kind*alt**2
+ endif
+ else
+ if (alt.le.4.0_r_kind) then
+ repe_gps=0.7285212_r_kind-1.1138755_r_kind*alt+0.2311123_r_kind*alt**2
+ elseif (alt.le.r18.and.alt.gt.4.0_r_kind) then
Please replace .gt. with > and .le. with <= on line 657.
------------------------------
In src/gsi/setupbend.f90
<#169 (comment)>:
> - endif ! (last_pass)
+ endif ! (last_pass)
end do ! i=1,nobs
Please address the indentation between lines 981 and 1246 (the endif on
line 1246 should be indented to not be on the same line as end do on line
1247).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#169 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGNN635KJOQQBP3OFCVVFKDTP6Z55ANCNFSM45U5KIXQ>
.
|
|
For updating the PR to ensure that there is only a single commit, please see Redmine's: git commit --amend will allow you to commit changes and not make additional commits. The only difference is that you will need to use: git push origin master --force to push changes back to repository. Mike |
|
WCOSS_D Regression Tests As Mike found, the following regression tests fail on WCOSS_D:
Failure of the Failures of the As a test, the PR #169 change to For additional information regarding the delz bug files, please see issue #117 and PR #116. |
RussTreadon-NOAA
force-pushed
the
master
branch
2 times, most recently
from
f027f58
to
e37c517
Compare
There was a problem hiding this comment.
One final comment, then this work will be ready for the review committee. On line 590, please remove the extra indentation (qcfail should align with the previous entries). Additionally, will there be anything for the above section of the if statement logic (line 591). If not, then should this line be removed as well?
|
The due date for the review committee has past with no feedback. I will now give final approval to these changes and merge them to the authoritative repository. |
AndrewEichmann-NOAA
added a commit
to AndrewEichmann-NOAA/GSI
that referenced
this pull request
Jun 21, 2021
commit 67705a1 Merge: 5e53aaf 18afa96 Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com> Date: Fri Jun 11 10:55:08 2021 -0400 Merge branch 'NOAA-EMC:master' into master commit 18afa96 Author: michael.lueken <Michael.Lueken@noaa.gov> Date: Thu Jun 10 11:57:29 2021 +0000 master: Updated fix/rev2 use flags for CrIS NPP due to LW band anomalies (global_satinfo.txt and added gfsv16_historical/global_satinfo.txt.2021052118 commit 51a6564 Merge: 820ee80 d199ed5 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Thu Jun 10 07:48:55 2021 -0400 Merge pull request NOAA-EMC#169 from RussTreadon-NOAA/master GitHub Issue NOAA-EMC#120. Merge GFS v16.1.1 DA changes into master commit d199ed5 Author: russ.treadon <Russ.Treadon@noaa.gov> Date: Thu May 27 19:08:39 2021 +0000 GitHub Issue NOAA-EMC#120. merge GFS v16.1.1 DA changes into master commit 820ee80 Merge: 6585234 86d4071 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Fri May 28 11:34:46 2021 -0400 Merge pull request NOAA-EMC#155 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_src GitHub Issue NOAA-EMC#118. EFSOI additions to util/EFSOI-Utilities/src directory. commit 86d4071 Author: michael.lueken <Michael.Lueken@noaa.gov> Date: Fri May 28 15:31:10 2021 +0000 GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific util source code. commit 6585234 Merge: 6cec754 efaa7cf Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Fri May 28 11:20:54 2021 -0400 Merge pull request NOAA-EMC#166 from comgsi/prMaster GitHub Issue NOAA-EMC#167. Change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly. commit efaa7cf Author: Guoqing.Ge <guoqing.ge@noaa.gov> Date: Wed May 26 15:51:51 2021 -0600 change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly commit 5e53aaf Merge: e54683c 6cec754 Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com> Date: Mon May 24 14:34:33 2021 -0400 Merge branch 'NOAA-EMC:master' into master commit 6cec754 Merge: 6a6ac4e 3cc26ec Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Fri May 21 13:48:26 2021 -0400 Merge pull request NOAA-EMC#147 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_scripts GitHub Issue NOAA-EMC#118. EFSOI additions to util/EFSOI-Utilities/scripts directory. commit 6a6ac4e Merge: 1162d92 62c884c Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Thu May 20 11:03:36 2021 -0400 Merge pull request NOAA-EMC#146 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_jobs GitHub Issue NOAA-EMC#118. EFSOI additions to jobs directory for issue. commit 1162d92 Merge: 6e38b98 77a729e Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Wed May 19 11:02:40 2021 -0400 Merge pull request NOAA-EMC#157 from comgsi/tmpdtc GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure. commit 6e38b98 Merge: b511ba0 00eb5da Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Wed May 19 07:27:08 2021 -0400 Merge pull request NOAA-EMC#164 from EdwardSafford-NOAA/master GitHub Issue NOAA-EMC#160. Correct data file location problem. commit 00eb5da Author: Edward.Safford <edward.safford@noaa.gov> Date: Tue May 18 16:31:34 2021 +0000 GitHub Issue NOAA-EMC#160. Correct data file location problem. commit b511ba0 Author: michael.lueken <Michael.Lueken@noaa.gov> Date: Tue May 18 14:38:15 2021 +0000 GitHub Issue NOAA-EMC#126. Update global_convinfo.txt and prepobs_errtable.global for high resolution Raob data. commit 66db434 Merge: dcb735a 23ec8ef Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Tue May 18 10:06:16 2021 -0400 Merge pull request NOAA-EMC#149 from jderber-NOAA/master GitHub Issue NOAA-EMC#126. Add use of high resolution Raob data. commit 77a729e Author: Guoqing.Ge <guoqing.ge@noaa.gov> Date: Fri May 14 11:15:32 2021 -0600 GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure. commit e54683c Merge: f69c3c8 b31b851 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu May 13 14:39:23 2021 +0000 Merge branch 'master' of github.com:AndrewEichmann-NOAA/GSI commit f69c3c8 Merge: 1dc5f83 dcb735a Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu May 13 14:37:10 2021 +0000 Merge branch 'master' of github.com:NOAA-EMC/GSI commit 3cc26ec Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu May 13 14:28:03 2021 +0000 GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI additions to util/EFSOI-Utilities/scripts directory. commit 62c884c Author: Michael Lueken <michael.lueken@noaa.gov> Date: Tue May 11 14:31:14 2021 +0000 GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific additions to jobs. commit 23ec8ef Author: john.derber <John.Derber@noaa.gov> Date: Mon Apr 26 19:29:18 2021 +0000 GitHub Issue NOAA-EMC#126. Add use of high resolution Raob data. commit dcb735a Merge: c502c92 7939d47 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Mon May 3 12:57:43 2021 -0400 Merge pull request NOAA-EMC#153 from lbi2018/master GitHub Issue NOAA-EMC#152. commit b31b851 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Fri Apr 30 15:34:59 2021 +0000 Should not have gone into master Revert "EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118" This reverts commit c9b8221. commit c9b8221 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Fri Apr 30 15:30:59 2021 +0000 EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118 commit 7939d47 Author: Li.Bi@noaa.gov <Li.Bi@noaa.gov> Date: Wed Apr 28 13:15:30 2021 +0000 GitHub Issue NOAA-EMC#152. Update of modulefile.ProdGSI.wcoss_c and get_gefs_for_regional.f90 bug fixes. commit c502c92 Merge: 39ed5fa 5d77565 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Mon Apr 26 10:22:12 2021 -0400 Merge pull request NOAA-EMC#151 from EdwardSafford-NOAA/master GitHub Issue NOAA-EMC#150. Correct OznMon read diag issue. commit 5d77565 Author: edward.safford <edward.safford@noaa.gov> Date: Fri Apr 23 19:42:54 2021 +0000 GitHub Issue NOAA-EMC#150. Correct OznMon read diag issue. commit 39ed5fa Merge: 02d5ce6 1e6fd61 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Tue Apr 13 09:37:05 2021 -0400 Merge pull request NOAA-EMC#144 from EdwardSafford-NOAA/master GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes. commit 1e6fd61 Author: Edward.Safford <edward.safford@noaa.gov> Date: Fri Apr 9 14:40:01 2021 +0000 GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes. commit 1dc5f83 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu Apr 8 21:15:51 2021 +0000 removing EFSOI source files until they are merged into GSI master upstream
AndrewEichmann-NOAA
added a commit
to AndrewEichmann-NOAA/GSI
that referenced
this pull request
Jun 21, 2021
commit 67705a1 Merge: 5e53aaf 18afa96 Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com> Date: Fri Jun 11 10:55:08 2021 -0400 Merge branch 'NOAA-EMC:master' into master commit 18afa96 Author: michael.lueken <Michael.Lueken@noaa.gov> Date: Thu Jun 10 11:57:29 2021 +0000 master: Updated fix/rev2 use flags for CrIS NPP due to LW band anomalies (global_satinfo.txt and added gfsv16_historical/global_satinfo.txt.2021052118 commit 51a6564 Merge: 820ee80 d199ed5 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Thu Jun 10 07:48:55 2021 -0400 Merge pull request NOAA-EMC#169 from RussTreadon-NOAA/master GitHub Issue NOAA-EMC#120. Merge GFS v16.1.1 DA changes into master commit d199ed5 Author: russ.treadon <Russ.Treadon@noaa.gov> Date: Thu May 27 19:08:39 2021 +0000 GitHub Issue NOAA-EMC#120. merge GFS v16.1.1 DA changes into master commit 820ee80 Merge: 6585234 86d4071 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Fri May 28 11:34:46 2021 -0400 Merge pull request NOAA-EMC#155 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_src GitHub Issue NOAA-EMC#118. EFSOI additions to util/EFSOI-Utilities/src directory. commit 86d4071 Author: michael.lueken <Michael.Lueken@noaa.gov> Date: Fri May 28 15:31:10 2021 +0000 GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific util source code. commit 6585234 Merge: 6cec754 efaa7cf Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Fri May 28 11:20:54 2021 -0400 Merge pull request NOAA-EMC#166 from comgsi/prMaster GitHub Issue NOAA-EMC#167. Change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly. commit efaa7cf Author: Guoqing.Ge <guoqing.ge@noaa.gov> Date: Wed May 26 15:51:51 2021 -0600 change GSIWRFIO_LIB to WRF_IO_LIB and update build.comgsi accordingly commit 5e53aaf Merge: e54683c 6cec754 Author: AndrewEichmann-NOAA <58948505+AndrewEichmann-NOAA@users.noreply.github.com> Date: Mon May 24 14:34:33 2021 -0400 Merge branch 'NOAA-EMC:master' into master commit 6cec754 Merge: 6a6ac4e 3cc26ec Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Fri May 21 13:48:26 2021 -0400 Merge pull request NOAA-EMC#147 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_util_EFSOI_scripts GitHub Issue NOAA-EMC#118. EFSOI additions to util/EFSOI-Utilities/scripts directory. commit 6a6ac4e Merge: 1162d92 62c884c Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Thu May 20 11:03:36 2021 -0400 Merge pull request NOAA-EMC#146 from AndrewEichmann-NOAA/EXP-efso_fv3_PR_jobs GitHub Issue NOAA-EMC#118. EFSOI additions to jobs directory for issue. commit 1162d92 Merge: 6e38b98 77a729e Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Wed May 19 11:02:40 2021 -0400 Merge pull request NOAA-EMC#157 from comgsi/tmpdtc GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure. commit 6e38b98 Merge: b511ba0 00eb5da Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Wed May 19 07:27:08 2021 -0400 Merge pull request NOAA-EMC#164 from EdwardSafford-NOAA/master GitHub Issue NOAA-EMC#160. Correct data file location problem. commit 00eb5da Author: Edward.Safford <edward.safford@noaa.gov> Date: Tue May 18 16:31:34 2021 +0000 GitHub Issue NOAA-EMC#160. Correct data file location problem. commit b511ba0 Author: michael.lueken <Michael.Lueken@noaa.gov> Date: Tue May 18 14:38:15 2021 +0000 GitHub Issue NOAA-EMC#126. Update global_convinfo.txt and prepobs_errtable.global for high resolution Raob data. commit 66db434 Merge: dcb735a 23ec8ef Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Tue May 18 10:06:16 2021 -0400 Merge pull request NOAA-EMC#149 from jderber-NOAA/master GitHub Issue NOAA-EMC#126. Add use of high resolution Raob data. commit 77a729e Author: Guoqing.Ge <guoqing.ge@noaa.gov> Date: Fri May 14 11:15:32 2021 -0600 GitHub Issue NOAA-EMC#158. Updates for community users to adopt the NOAA hpc-stack structure. commit e54683c Merge: f69c3c8 b31b851 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu May 13 14:39:23 2021 +0000 Merge branch 'master' of github.com:AndrewEichmann-NOAA/GSI commit f69c3c8 Merge: 1dc5f83 dcb735a Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu May 13 14:37:10 2021 +0000 Merge branch 'master' of github.com:NOAA-EMC/GSI commit 3cc26ec Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu May 13 14:28:03 2021 +0000 GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI additions to util/EFSOI-Utilities/scripts directory. commit 62c884c Author: Michael Lueken <michael.lueken@noaa.gov> Date: Tue May 11 14:31:14 2021 +0000 GitHub Issue NOAA-EMC#118. Implement EFSOI process in FV3 GFS workflow - EFSOI-specific additions to jobs. commit 23ec8ef Author: john.derber <John.Derber@noaa.gov> Date: Mon Apr 26 19:29:18 2021 +0000 GitHub Issue NOAA-EMC#126. Add use of high resolution Raob data. commit dcb735a Merge: c502c92 7939d47 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Mon May 3 12:57:43 2021 -0400 Merge pull request NOAA-EMC#153 from lbi2018/master GitHub Issue NOAA-EMC#152. commit b31b851 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Fri Apr 30 15:34:59 2021 +0000 Should not have gone into master Revert "EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118" This reverts commit c9b8221. commit c9b8221 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Fri Apr 30 15:30:59 2021 +0000 EFSOI-specific fortran source from branch EXP-efso_fv3 - GSI issue NOAA-EMC#118 commit 7939d47 Author: Li.Bi@noaa.gov <Li.Bi@noaa.gov> Date: Wed Apr 28 13:15:30 2021 +0000 GitHub Issue NOAA-EMC#152. Update of modulefile.ProdGSI.wcoss_c and get_gefs_for_regional.f90 bug fixes. commit c502c92 Merge: 39ed5fa 5d77565 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Mon Apr 26 10:22:12 2021 -0400 Merge pull request NOAA-EMC#151 from EdwardSafford-NOAA/master GitHub Issue NOAA-EMC#150. Correct OznMon read diag issue. commit 5d77565 Author: edward.safford <edward.safford@noaa.gov> Date: Fri Apr 23 19:42:54 2021 +0000 GitHub Issue NOAA-EMC#150. Correct OznMon read diag issue. commit 39ed5fa Merge: 02d5ce6 1e6fd61 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Tue Apr 13 09:37:05 2021 -0400 Merge pull request NOAA-EMC#144 from EdwardSafford-NOAA/master GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes. commit 1e6fd61 Author: Edward.Safford <edward.safford@noaa.gov> Date: Fri Apr 9 14:40:01 2021 +0000 GitHub Issue NOAA-EMC#123. OznMon update and bugzilla fixes. commit 1dc5f83 Author: andrew.eichmann <andrew.eichmann@noaa.gov> Date: Thu Apr 8 21:15:51 2021 +0000 removing EFSOI source files until they are merged into GSI master upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly merges GFS v16.1.1 DA changes from a forked snapshot of release/gfsda.v16.1.0_merge into the authoritative master. The changes in release/gfsda.v16.1.0_merge are documented in issue #120. Additional details are found in SCN21-52.