Including changes to use OS 3.5.1 and changes in master #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove existing daylighting controls by default for prototype and prm workflow methods
…gMaximumSystemAirFlowRatio' when using OS version 2.7.0 and later. Apparently, this was being done behind the scenes anyway but NREL decided to remove the 'setMinimumSystemAirFlowRatio' entirely by OS 3.5.1.
use 90.1-2019 value for 150 ton chiller by cooling type
This reverts commit 2a108e3.
- set fan flow rate based on capacity, not a fixed value per #684 - check schedule object type for HPWH swh sch EMS actuator - add tests
fix typo and delete extra methods
applying the boiler efficiency will rename it later
Add check for plant loop cooling fuels for 'OS_HeatExchanger_FluidToFluid' objects. Fixes issue #754
change prm boiler naming
support OS_HeatExchanger_FluidToFluid in fuels
adding hpwh ems schedule override
Merge from commit eea3c93
This reverts commit 3fdc061.
- clone and assign individual lights objects to each space - use the space object in E+9.6 / OS v3.3 and higher versions - hardcode space floor area as a number instead of an internal variable (will need to delete and re-run method if space sizes change)
Update simulation.rb
after cloning the space type lights to the individual spaces, delete the lights on the space type objects. Fixes the issue of having duplicate lights
update 90.1-2016 and 90.1-2019 regression models
NRCan merge using OS351
break out lights in EMS code
Correcting Warehouse wall orientation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.