Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appendix G updates #1719

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Appendix G updates #1719

merged 7 commits into from
Apr 5, 2024

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Apr 4, 2024

Pull request overview

Latest Appendix G changes

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@lymereJ lymereJ added the AppendixG Methods to enable the Appendix G model workflow label Apr 4, 2024
@mdahlhausen
Copy link
Collaborator

Presumably there is more to this PR than just the two one-line changes?

@lymereJ
Copy link
Collaborator Author

lymereJ commented Apr 4, 2024

The AppendixG_Dev branch merged not that long ago (#1689) and #1692 is not ready to merge.

@mdahlhausen mdahlhausen merged commit ca73ab2 into master Apr 5, 2024
0 of 2 checks passed
@mdahlhausen mdahlhausen changed the title Latest Appendix G changes Appendix G updates Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AppendixG Methods to enable the Appendix G model workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants