Merges cumulated changes in nrcan_450 #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default construction needs a value for solar transmittance, otherwise tests will fail that rely on looking up properties for default constructed standard glazing
change surfaces_get_conductance to return nil instead of 0 if no surfaces applied, or the conductance is 0
V0.6.0.rc1
Fix/necb envelope tests
…turalGas or Electricity if a HP primary heating fuel is used with a vintage building.
… NaturalGas or Electricity if a HP primary heating fuel is used with a vintage building.
splits out model_add_residential_erv into model_add_residential_erv and model_add_residential_ventilator. The method was previously adding ventilation with no heat recovery, and the zero values were causing issues in an EnergyPlus method. The split adds a ventilator instead when energy recovery is not required, along with a corresponding exhaust fan.
…ction objects. Updating qaqc_report_expected_result.json to match new results.
…ction objects. Updating qaqc_report_expected_result.json to match new results.
… test_necb_qaqc_reporting.rb output. The openstudio-standards revision number changes with every commit causing the test to always fail.
… test_necb_qaqc_reporting.rb output. The openstudio-standards revision number changes with every commit causing the test to always fail.
Fixing NECB qaqc reporting
Explicitly run zone, system, and plant sizing due to changes in NREL/OpenStudio#5118
Split out residential ventilation methods
0.6.0.rc2 release
openstudio-standards works across many versions of ruby, openstudio, and energyplus. Don't have a CI check that expects fixed versions for those.
remove os_standards_revision tag
remove ci check that fixes software versions
…ts to revised cop_heating_to_cop_heating_no_fan method.
…an_merge_into_nrcan
OpenStudio release with Ruby 3.2.2 requires bundler 2.4
…puts in csv with timesteps as a column instead of having timesteps in the first row like the hourly output, and corrected number of total timesteps in the whole year to have the right number of rows in the generated csv file
…estep_data method in btap_datapoint.rb
nrcan_447: Add capability to extract timestep outputs
…culating annual electricity energy and peak cost using oerd rates
Including nrcan branch changes into nrcan_446
…clude oerd electricity cost in simulation output file; Added dummy values for three provinces of YT, NT, NU in the oerd_electricity_cost method in btap_data.rb as oerd electricity rate did not cover electricity rates for these provinces
nrcan_448: Add a method for calculating utility cost considering peak
Including HS15 CASHP
Merging nrcan branch into nrcan_446 branch
Initializes nrcan_446 branch: skylights & wells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.