Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2713 team type component #2865

Closed
wants to merge 57 commits into from
Closed

#2713 team type component #2865

wants to merge 57 commits into from

Conversation

Aaryan1203
Copy link
Contributor

@Aaryan1203 Aaryan1203 commented Oct 3, 2024 •
edited
Loading

Changes

Created the team type component
Created a helper to download an image

For testing purposes I only had a picture in the software division just to see what it would look like so heres a video for that

Screen.Recording.2024-10-03.at.9.19.47.AM.mov

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2713

Aaryan1203 and others added 30 commits July 23, 2024 15:31
@Aaryan1203
#2708 added description field to team type and cerated edit team type…
c3fb7c0 
… description field
@Aaryan1203
#2708 prettier and frontend test
0a84e2a
@Aaryan1203
#2708 added unit tests
00d2ee4
@Aaryan1203
#2708 prettier
9b423df
@Aaryan1203
#2708 typescript check
a587bc7
@superhvarn
#2708 edit image endpoint for teamType and tests
a1955c8
@superhvarn
#2708 prettier
4c9368c
@Aaryan1203
#2708 added description to admin tools page
5871db9
@Aaryan1203
Merge branch '#2708-edit-team-type-description-endpoint' of https://g…
c12307b 
…ithub.com/Northeastern-Electric-Racing/FinishLine into #2708-edit-team-type-description-endpoint
@Aaryan1203
#2708 prettier and tests
2412b18
@Aaryan1203
#2708 edit team type now works
29cad5c
@Aaryan1203
#2708 linting
cccc12f
@Aaryan1203
#2708 renamed setImage endpoint to setTeamTypeImage
328886f
@Aaryan1203
#2709 prettier
516f880
@Aaryan1203
#2708 fixed invalid query bug and moved team type apis into respectiv…
c9603e6 
…e folders
@Aaryan1203
#2708 prettier
4c7044b
@Aaryan1203
#2708 prettier
41b1129
@Aaryan1203
#2735 started endpoint
e4c8768
@Aaryan1203
#2708 merged develop
50e454d
@Aaryan1203
#2708 used useHistoryState and useFormPersist for team type modals
b01825a
@Aaryan1203
#2708 prettier
0d35159
@Aaryan1203
#2735 merged develop
2980b59
@Aaryan1203
#2735 updated endpoint to use proper form data
b2e9969
@Aaryan1203
#2708 prettier linting, tsc, and tests
7fc50bd
@Aaryan1203
#2708 spelling and naming fixes
8cd687e
@Aaryan1203
#2708 linting
0ff651a
@Aaryan1203
#2708 created upload image endpoint
29e75ce
@Aaryan1203
#27089 merge conflicts
fe5830d
@Aaryan1203
#2708 merge conflicts
6061450
@Aaryan1203
#2708 updated setTeamTypeImage and fixed github actions
99dfaf9
Aaryan1203 and others added 25 commits August 14, 2024 12:23
@Aaryan1203
#2708 removed comment
caadc14
@Aaryan1203
#2708 fixed tests
01a9d75
@Aaryan1203
#2708 each upload is for its own specific team type
41ff89a
@Aaryan1203
merge conflicts
f6a07ce
@Aaryan1203
merge conflitcs
844230f
@Aaryan1203
#2708 fixing emrge conflitcs
00c5777
@Aaryan1203
#2708 more merge conflicts
afecab9
@Aaryan1203
#2708 editing team type edits the right one
d34660a
@Aaryan1203
#2708 merge conflitcs
6ef1ddb
@Aaryan1203
#2708 tsc and prettier
3369737
@Aaryan1203
#2708 prettier
7ed4bf2
@Aaryan1203
#2708 created NERUploadButton component
17233c2
@Aaryan1203
#2708 linting
65fa965
@Aaryan1203
#2708 holy shit
abfef07
@Aaryan1203
#2708 works
c39f00a
@alaneng-neu
#1934 Create delete account code endpoint
bba4b85
@walker-sean
Merge pull request #2832 from Northeastern-Electric-Racing/#1934-dele…
3d4bd95 
…te-account-code-endpoint

#1934 Create delete account code endpoint
@Aaryan1203
Created get organization endpoint and hook
c8ac030
@walker-sean
Merge pull request #2840 from Northeastern-Electric-Racing/getorganiz…
322d8ac 
…ation-endpoint

Created get organization endpoint and hook
@Aaryan1203
Merge branch 'develop' into #2708-edit-team-type-description-endpoint
2f8c584
@Aaryan1203
#2708 fixed image url
1540118
@Aaryan1203
#2708 image upload and download works
c3fff30
@Aaryan1203
#2708 fixed picture switching
aa7c954
@Aaryan1203
Merge branch 'feature/recruitment_and_onboarding' into #2713-team-typ…
7d57ae7 
…e-component
@Aaryan1203
#2713 started division info comopnent
87b2b1d
@Aaryan1203 Aaryan1203 self-assigned this Oct 3, 2024
@Aaryan1203 Aaryan1203 changed the base branch from develop to feature/recruitment_and_onboarding October 3, 2024 12:17
@Aaryan1203 Aaryan1203 closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aaryan1203 Aaryan1203

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Recruitment] - Create Reusable DivisionsInfo Component
4 participants
@Aaryan1203 @superhvarn @alaneng-neu @walker-sean