Merge branch dev into main (NuGet.Jobs and ServerCommon merge) #10135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating NuGet dependencies * Missing property added.
[ReleasePrep][2023-07-18]RI dev to main
* Package source mapping.
…reCredential change
#411) * Function for adding new package source mappings to nuget.config files. * Defaulting to `$PWD` for relative paths * Array of patterns, so we save once. Package source mapping section presence check.
Transition from Microsoft.Azure.KeyVault to Azure.Security.KeyVault
Add -SkipArtifacts for further parallelism
This is for consistent with other projects
Merge ServerCommon repository into NuGetGallery
* Sanitize URLs for logging * Fix container URI construction when directory is provided * Remove flaky assertion
A building block for NuGet/Engineering#5082
* Add auth to V3 monitoring search cursor URLs * Use -clientId for managed identity auth on search cursors * Allow UseManagedIdentity to be set per search instance
…when checking if blobs are synchronized (#10123) * Handle blob name generate when base URI scheme does not match This was causing monitoring2monitoring to fail with an invalid blob name (double slashes). Scrub blob URL for logging * Do not consider a blob as synchronize if the size is difference * Add UTs
…ln (#10130) Run simple validations on the .csproj: - Test projects should only be in one solution (all solutions are tests in CI, reduce duplication) - Determine whether a dependency package project common vs. gallery vs. jobs dynamically - Verify AssemblyInfo.g.cs is only written once per project
* Add UseNuGetBuildExtensions to all entry points * Move SdkProjects.props to Directory.Build.props, rename to targets * Move to targets file only, NUGET_SNK_PATH is set after props for legacy csproj * Remove unnecessary package references
drewgillies
previously approved these changes
Aug 16, 2024
clairernovotny
previously approved these changes
Aug 16, 2024
joelverhagen
dismissed stale reviews from clairernovotny and drewgillies
via
ef1455c
martinrrm
approved these changes
Aug 16, 2024
ryuyu
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the NuGet.Jobs and ServerCommon source trees into
mainbranch. They have already been merged intodevbranch as of #10091 and #10109.That's a lot of content to review, so let's focus on the changes NOT including NuGet.Jobs and ServerCommon. I have listed them here with diff links to illustrate how I found them:
dev: 9684321...ef1455cIn other words, these are the changes made to NuGetGallery or post-merge NuGet.Jobs and ServerCommon states.
DEV environment has latest
devbranch deployment so you should be able to verify your changes there right now if you are worries:https://dev.nugettest.org/
The rollout plan is to deploy the following jobs and services: