Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][15.0] account_payment_return #536

Closed
wants to merge 46 commits into from
Closed

[MIG][15.0] account_payment_return #536

wants to merge 46 commits into from

Conversation

ChrisOForgeFlow
Copy link
Contributor

DavidJForgeFlow
DavidJForgeFlow suggested changes Sep 1, 2022
View reviewed changes
Copy link

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review 👍, one change in Readme and done!

account_payment_return/README.rst Outdated Show resolved Hide resolved
@ValentinVinagre
Copy link
Contributor

@ChrisOForgeFlow Can you check the comments? thanks 😄

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-account_payment_return branch from 1a656b5 to 1e1c6f0 Compare September 30, 2022 12:07
@oca-clabot
Copy link

Hey @ChrisOForgeFlow, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@ChrisOForgeFlow
Copy link
Contributor Author

@ChrisOForgeFlow Can you check the comments? thanks smile

Done!, thanks

sergio-teruel and others added 24 commits November 28, 2022 19:43
@sergio-teruel @ChrisOForgeFlow
account_payment_return: This module implements the return of invoice …
05bdb07 
…payments.
@pedrobaeza @ChrisOForgeFlow
account_payment_return: Improve behaviour
6d4c0e4
@carlosdauden @ChrisOForgeFlow
account_payment_return: Implement find match with reference field (#2)
accf8fa 
[IMP] account_payment_return: Implement find match with reference field
@carlosdauden @ChrisOForgeFlow
account_payment_return: Improvements to suite (OCA#107)
5f5ec4a
@carlosdauden @ChrisOForgeFlow
account_payment_return: Migrate 8.0 to 9.0
3a6c4b9
@pedrobaeza @ChrisOForgeFlow
account_payment_return: Make line date editable
1842f50 
When entering manually returns, you need to change the line date.

This commit also allows to use header date as defaut line date.
@pedrobaeza @ChrisOForgeFlow
account_payment_retun: Add hooks
3537b41 
* For journal entry dictionary.
* For extra return lines.

account_payment_return: Period not present in 9.0
@chienandalu @ChrisOForgeFlow
[MIG] account_payment_return: Migration to 10.0
bf40db8
@ChrisOForgeFlow
[IMP] account_payment_return: Add return expenses functionality (OCA#156
929f206 
)
@ChrisOForgeFlow
[11.0][MIG] account_payment_return
14fd5e8
@ThomasBinsfeld @ChrisOForgeFlow
[MIG] Account Payment Return to 12.0
b28d982
@ThomasBinsfeld @ChrisOForgeFlow
[ADD] Payment Return Import SEPA: reason additional info refs OCA#227
b116f16 
New free text field on return lines: additional information on return reason.
This field is populated in account_payment_return_import_sepa_pain with the content of the AddtlInf tag.
This is useful when the return reason code is NARR, meaning the reason description does not match any known code but is in this tag.
@ThomasBinsfeld @ChrisOForgeFlow
[IMP] account_payment_return_import_sepa_pain: missing return reasons (…
1a80bda 
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
@ThomasBinsfeld @ChrisOForgeFlow
[REF] Account Payment Return: action_confirm refactoring
9d44a77 
Use prepare methods for created move and move lines
@ThomasBinsfeld @ChrisOForgeFlow
[IMP] Payment Return: optional automatic reconciliation
4229607
@ThomasBinsfeld @ChrisOForgeFlow
[12.0] [ADD] account_payment_return_import_iso20022 (OCA#236)
345a514 
* [ADD] Account Payment Return Import CAMT: parser camt.054.001.02 files

* [REF] Account Payment Return Import ISO20022: merge the two iso20022 modules in one

* [REF] Account Payment Return Import: use SavepointCase instead of TransactionCase

* [REF] Increase global code coverage
@ThomasBinsfeld @ChrisOForgeFlow
[IMP] Payment Return: new computed total field on payment return
340bbdc
@ThomasBinsfeld @ChrisOForgeFlow
[IMP] Payment Return: search view
62ec167
@ChrisOForgeFlow
[IMP] account_payment_return: black, isort
08d0c6d
@ChrisOForgeFlow
[MIG] account_payment_return: Migration to 13.0
2ff410f
@ChrisOForgeFlow
[IMP] multi-company domain: modified for standard outlined in migrati…
7d1c6f0 
…on guide v13

[FIX] account_payment_return: Fix multi-company rules + migration scripts

[FIX] account_payment_return
@astirpe @ChrisOForgeFlow
[FIX] Moves canceling after latest changes on Odoo 13.0
9f0c890
@celm1990 @ChrisOForgeFlow
FIX: remove domain field supplier not exist anymore since V13
3ae6d16
@joao-p-marques @ChrisOForgeFlow
[MIG] account_payment_return: Migration to 14.0
c570f90 
TT28727
oca-travis and others added 22 commits November 28, 2022 19:43
@oca-travis @ChrisOForgeFlow
[UPD] Update account_payment_return.pot
ba19c6c
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
c136537
@ibuioli @ChrisOForgeFlow
Added translation using Weblate (Spanish (Argentina))
f3d68e0
@bosd @ChrisOForgeFlow
Translated using Weblate (Dutch)
d4d28d3 
Currently translated at 54.6% (53 of 97 strings)

Translation: account-payment-14.0/account-payment-14.0-account_payment_return
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_return/nl/
@ibuioli @ChrisOForgeFlow
Translated using Weblate (Spanish (Argentina))
86c5a9b 
Currently translated at 61.8% (60 of 97 strings)

Translation: account-payment-14.0/account-payment-14.0-account_payment_return
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_return/es_AR/
@ibuioli @ChrisOForgeFlow
Translated using Weblate (Spanish (Argentina))
34e3066 
Currently translated at 100.0% (97 of 97 strings)

Translation: account-payment-14.0/account-payment-14.0-account_payment_return
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_return/es_AR/
@bosd @ChrisOForgeFlow
Translated using Weblate (Dutch)
226c0e0 
Currently translated at 57.7% (56 of 97 strings)

Translation: account-payment-14.0/account-payment-14.0-account_payment_return
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_return/nl/
@rousseldenis @ChrisOForgeFlow
[14.0][FIX] account_payment_return: Register payment is posting autom…
7747193 
…atically payments

A new check has been introduced in
odoo/odoo@80c2818

So, in test, when creating payment with payment register wizard, as
payments are automatically posted, duplicate posting is now forbidden.

https://github.com/odoo/odoo/blob/14.0/addons/account/wizard/account_payment_register.py#L512
@OCA-git-bot @ChrisOForgeFlow
account_payment_return 14.0.1.0.1
74e771a
@carlosdauden @ChrisOForgeFlow
[IMP] account_payment_return: Add general type in journal selection t…
b0ad4f6 
…o return payment

TT29784
@OCA-git-bot @ChrisOForgeFlow
account_payment_return 14.0.1.0.2
499153d
@ao-landoo @ChrisOForgeFlow
[FIX] account_payment_return: use journal return account
22f7293
@OCA-git-bot @ChrisOForgeFlow
account_payment_return 14.0.1.0.3
91aaa8d
@etobella @ChrisOForgeFlow
[IMP] account_payment_return: Mark as Mature
a8fa536
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
9d712f3
@LudLaf @ChrisOForgeFlow
Translated using Weblate (Spanish)
ba4aef7 
Currently translated at 65.9% (64 of 97 strings)

Translation: account-payment-14.0/account-payment-14.0-account_payment_return
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_return/es/
@Yvesldff @ChrisOForgeFlow
Translated using Weblate (French)
bfcdf32 
Currently translated at 74.2% (72 of 97 strings)

Translation: account-payment-14.0/account-payment-14.0-account_payment_return
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_return/fr/
@jabelchi @ChrisOForgeFlow
Translated using Weblate (Catalan)
dea6eaf 
Currently translated at 24.7% (24 of 97 strings)

Translation: account-payment-14.0/account-payment-14.0-account_payment_return
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_return/ca/
@cormaza @ChrisOForgeFlow
[IMP] account_payment_return: black, isort, prettier
c988d8b
@ChrisOForgeFlow
[MIG][15.0] account_payment_return
61851c6
@ChrisOForgeFlow
[FIX] Path on readme
af60fef
@ChrisOForgeFlow @victoralmau
Update account_payment_return/tests/test_payment_return.py
e151455 
Co-authored-by: Víctor Martínez <victoralmau@users.noreply.github.com>
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-account_payment_return branch from 49eb1de to e151455 Compare November 28, 2022 19:44
@victoralmau
Copy link
Member

Can you merge your changes in a single commit (migration commit)?

carlosdauden
carlosdauden suggested changes Feb 6, 2023
View reviewed changes
account_payment_return/models/payment_return.py
"name": move.ref,
"debit": 0.0,
"credit": total_amount,
"account_id": self.journal_id.default_account_id.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Outstanding Receipts Account

@ao-landoo
Copy link
Contributor

@ChrisOForgeFlow are you continuing with this PR?

@carlosdauden
Copy link
Contributor

As there was no response I am preparing a new PR

@carlosdauden
Copy link
Contributor

carlosdauden commented Mar 20, 2023 •
edited
Loading

Replaced by this: #610

@pedrobaeza pedrobaeza closed this Mar 21, 2023
@bizzappdev bizzappdev mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow requested changes

@carlosdauden carlosdauden carlosdauden requested changes

@victoralmau victoralmau victoralmau requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.