Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] Migration: l10n_it_fiscalcode #1931

Merged
merged 45 commits into from
Nov 30, 2020

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Oct 30, 2020

Porting del modulo l10n_it_fiscalcode dalla versione 12.0 alla 14.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

scigghia and others added 30 commits October 30, 2020 16:07
[FIX] fiscalcode field, near email field
[FIX] l10n_it_fiscalcode - wrong test data

[REF] Set all the modules of the master branches to "installable": False
moves all modules into a __unported__ directory
Added act_window_close to fiscalcode popup but doesn't seem to work
[PEP8] other fixes

Fix typo in traslation

Removed size attribute from name field

l10n_it_fiscalcode: removed unique constraint on company,fiscalcode

pylint fixes

Typo
[fiscalcode] remove useless join

[fiscalcode] change website to www.odoo-italia.org

[fiscalcode] added codicefiscale dipendence

[fiscalcode] added codicefiscale dependence

[fiscalcode] default fields new way(tm)

[fiscalcode] default fields new way(tm)
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
…th a try except. In this way the dependency will be checked before installing and will not raise ImportError if user doesn't use module.
[MIG] Migrate code to new api

[MIG] Replace YAML test with unittest

[MIG] Onchange with new api, upgrade XML

[MIG] Update README.rst

[MIG] Update Copyright

[MIG] Fix Readme and description

[FIX] Remove useless key in manifest

Update Manifest and Readme info

OCA Transbot updated translations from Transifex

[FIX] © -> Copyright

[FIX] Remove useless api
[FIX] Use % instead of positional in string
[FIX] Readme link's to python depends

[FIX] Pylint
OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
Currently translated at 100.0% (42 of 42 strings)

Translation: l10n-italy-11.0/l10n-italy-11.0-l10n_it_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-11-0/l10n-italy-11-0-l10n_it_fiscalcode/it/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 95.0% (38 of 40 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_fiscalcode/it/
@tafaRU
Copy link
Member

tafaRU commented Nov 27, 2020

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1931-by-tafaRU-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2020
Signed-off-by tafaRU
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1931-by-tafaRU-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@tafaRU
Copy link
Member

tafaRU commented Nov 27, 2020

@primes2h hai suggerimenti su come risolvere https://travis-ci.com/github/OCA/l10n-italy/jobs/449612121#L400? É accettabile se lasciamo solo una lingua?

Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@primes2h hai suggerimenti su come risolvere https://travis-ci.com/github/OCA/l10n-italy/jobs/449612121#L400? É accettabile se lasciamo solo una lingua?

Possiamo provare a fregarlo così (o in modo similare), vediamo se funziona.

Comment on lines 3 to 7
Installare il modulo Python: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.

**English**

Install the Python package: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Installare il modulo Python: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.
**English**
Install the Python package: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.
Installare il modulo Python per il `codice fiscale <https://pypi.python.org/pypi/codicefiscale>`_.
**English**
Install the `fiscal code <https://pypi.python.org/pypi/codicefiscale>`_ Python package.

Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@primes2h hai suggerimenti su come risolvere https://travis-ci.com/github/OCA/l10n-italy/jobs/449612121#L400? É accettabile se lasciamo solo una lingua?

Eventualmente ci sarebbe quest'altra soluzione:
https://stackoverflow.com/questions/5464627/how-to-have-same-text-in-two-links-with-restructured-text

Direi "as you like it" 😄

Comment on lines 3 to 7
Installare il modulo Python: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.

**English**

Install the Python package: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Installare il modulo Python: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.
**English**
Install the Python package: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`_.
Installare il modulo Python: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`__.
**English**
Install the Python package: `codicefiscale <https://pypi.python.org/pypi/codicefiscale>`__.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personalmente preferisco questa soluzione, grazie!

@tafaRU
Copy link
Member

tafaRU commented Nov 30, 2020

@primes2h puoi aggiornare la tua review?

Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU
Copy link
Member

tafaRU commented Nov 30, 2020

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1931-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 13a9755 into OCA:14.0 Nov 30, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9a5c7c8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.