[18.0] [MIG] partner_firstname: Migration to 18.0 #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it's working as is
Fix pylint errors
…avoid problem with the new API [FIX] partner_firstname : Remove the value checks in tests. With Odoo v8, the value checks in tests raise a Warning "2015-02-05 08:59:44,867 4590 WARNING 00846-develop-v8-9743ea-all openerp.modules.module: Found deprecated fast_suite or checks attribute in test module openerp.addons.partner_firstname.tests. These have no effect in or after version 8.0." With Runbot, we cannot have any Warning.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Fix wrong naming. Remove subclassing of exception, since there is only one. Rename exception according to PEP8. Reduce tests' redundancy. Add test for whitespace trimming. Use unicode for code & tests. Fix wrong comments. Split _name_inverse adding _name_clean_inverse. Conflicts: partner_firstname/models.py Remove license header in XML files. Preserve old view names. Credits to last translator. Increase coverage. Add args to exception to display the correct message in the UI. Execute _firstname_install when installing, and log it. Rename methods to follow guidelines. Better docstrings. Workaround odoo/odoo#6324. Fix users not being able to create companies. This happened because the invert method was not being called when using the UI, and because lastname & firstname fields were required while hidden. Add new tests and fix the resulting bugs. New tests, some fail. Add docs to test modules. Fix recursive onchange misbehavior & tests. Fix UI problem when lastname was u"". It should be `False` to avoid `required` errors. Use new() to create onchange records. Reduce redundancy in tests. Tests work with `mail` module installed now. Sometimes, the only way is to just skip them.
This fixes OCA#78 and adds new tests for it.
…tics. Conflicts: partner_contact_gender/__openerp__.py
- add missing authors - use reduced license header - move models in models directory - adapt views - show firstname, lastname only in edit mode - use company_type in views instead of is_company - adapt constraint on contacts [PORT][9.0] partner_firstname - remove hack to be able to edit user view. Fixed in odoo/odoo#cf63d4d277ef1ba02ff4ebcdae8583332a1775b1 [PORT][9.0] partner_firstname - Format of string in __openerp__.py [PORT][9.0] Adapt tests to take new constraint raising IntegrityError partner_firstname: Name is not mandatory if partner is an address [FIX] Ensure default values are computed for res.users Add test for shipping address with empty name partner_firstname: fix user creation User name field is required what is stoping to create a new user Fix user form with firstname and lastname asking for a mandatory name
…f adress 'type' is contact
* Prefer odoo to openerp & remove data tags * Move exceptions file out of models * Fix string selection in xpath * Rename res_users and add import * Fix api mismatches * Add missing param * Alphabetize imports * Remove readonly from computed field * Remove deprecated api.one * Add Tecnativa * Fix icon * Fix singleton issue * Add depends to compute
|
/ocabot migration partner_firstname |
SonoDavid
changed the title
xaviedoanhduy
approved these changes
Oct 22, 2024
|
This PR has the |
rousseldenis
approved these changes
Oct 22, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 22, 2024
|
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1865-by-rousseldenis-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
The merge failed, should I do any action in order to make it succeed? |
SonoDavid
force-pushed
the
18.0-mig-partner_firstname
branch
2 times, most recently
from
92608d9 to
ce2ec38
Compare
SonoDavid
force-pushed
the
18.0-mig-partner_firstname
branch
from
ce2ec38 to
249f435
Compare
|
Fixed testing and linting issues in this new MR (functionally the same) @rousseldenis |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 688f715. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.