[11.0][MIG] partner_identification #526

simahawk · 2017-11-29T14:14:20Z

squashed and reworded commits "meaningfully"

* [IMP] improve module description * [IMP] Remove useless comments * [FIX] Complete incomplete sentence * [IMP] Replace field 'state' by 'status' in res_partner_id_number * [IMP] Add new field 'Place of Issuance' * [FIX] Readme formatting * [IMP] status is now a selection field * [IMP] use method to provide the default value for validation_code * [IMP] Add help texts * [FIX] Add missing constrains on category_id in res_partner.id_number The number must be validated also when we change the category

Allow for context override of validations using ``id_no_validate``

OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option

yvaucher

Just some nitpicking otherwise LGTM

yvaucher · 2017-11-29T14:18:10Z

partner_identification/README.rst

@@ -1,3 +1,4 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
 .. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


You have twice the same line
You have twice the same line

yvaucher · 2017-11-29T14:19:09Z

partner_identification/__manifest__.py

@@ -1,17 +1,18 @@
 # -*- coding: utf-8 -*-


header for encoding can be removed utf8 is default

elicoidal

some details.
LGTM

elicoidal · 2017-11-30T00:24:46Z

partner_identification/__manifest__.py

+              'ACSONE SA/NV,'
+              'LasLabs,'
+              'Odoo Community Association (OCA)',
+    'website': 'https://odoo-community.org/',


better use the URL of the repo

elicoidal · 2017-11-30T00:25:46Z

partner_identification/models/__init__.py

@@ -0,0 +1,7 @@
+# -*- coding: utf-8 -*-


coding line is not necessary in v11 (P3)
remove copyright notice from __init__.py files too

MQT is not ready yet and logs warnings... I was trying to get a clear build. I'll remove them anyway ;)

But remember that warnings don't change green status.

lmignon · 2017-11-30T13:45:58Z

partner_identification/tests/test_res_partner.py

 class TestResPartner(common.SavepointCase):

-    @classmethod
-    def _init_test_model(cls, model_cls):


@simahawk Why do you remove this way to create test models? What's the problem?

@lmignon does not work on v11, it breaks transaction. In any case, my replacement sounded like less "black magic" and is working fine in a lot of modules ;)

@simahawk It breaks transaction because one line is missing to disable the commit done by Odoo when a model is created. self.env.cr.commit = mock.MagicMoxk() or self.env.cr.commit = lambda a: True
With your code, after the tests the partner model is modified into database.

what do you mean w/ modified? You run this only in test mode, so: db is a test one, everything is rolled back after tests (if you don't commit). Am I missing anything?

yajo · 2017-12-01T09:14:31Z

Another one with truncated git history due to rename. Could you fix that please? I think a special case for this should be added to https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

pedrobaeza · 2017-12-01T09:16:28Z

I'm not sure if that can be done. It's the only drawback of this method, but I think it's not the most important thing, as renamings should be exceptional cases (and more if everyone takes care of the names on the first review phase). Commit history is still in the corresponding branch.

yajo · 2017-12-01T09:43:59Z

🤔 I think that if we care about history, we care about history, and if we dont, we don't.

I got the method, it's not that hard:

# New temp branch to get the commits until the rename
git checkout -b tmp1 origin/10.0

# Extract oldest commits
module=partner_identifiers
git filter-branch --force --subdirectory-filter $module

# Simplify history by setting all commits directly in the good addon name
module=partner_identification
git filter-branch --force --tree-filter "mkdir -pv $module; git mv -k * $module" HEAD

# New temp branch to get the commits from the rename
git checkout -b 11.0-$module origin/10.0

# Extract commits from rename
git filter-branch --force --subdirectory-filter $module
git filter-branch --force --tree-filter "mkdir -pv $module; git mv -k * $module" HEAD

# Get all commits together
git rebase tmp1
git branch -D tmp1

# Rebase on 11.0 and do manual removal of unneeded commits (translations, addon rename...)
git rebase -i 11.0

# Add your migration commit
git cherry-pick 260925815802f4e7cf1aece2ad7f7a090f695aac

With this system, we'll avoid having the problem on 12.0 also because all history will be in partner_identification folder 😊

pedrobaeza · 2017-12-01T09:48:00Z

OK, I haven't dug enough. Let's try the procedure on some of the renamed modules to see if it works.

simahawk · 2017-12-01T10:15:47Z

I'll give it a try

grindtildeath · 2018-02-23T09:41:05Z

@simahawk Can you update commit history and squash your fixup commits ?

simahawk · 2018-02-26T08:10:45Z

@yajo I'm giving a try to your approach but there are no more commits before these:

$ g lg
*       4dc8550 2016-03-16 Laurent Mignon (ACSONE) (HEAD -> 11-mig-partner_identification-bis) [IMP] Rename partner_identifiers -> partner_identification
*       6153f76 2016-03-15 Laurent Mignon (ACSONE) [IMP] Add missing contributors in README.rst
*       3ab9f9c 2016-03-15 Laurent Mignon (ACSONE) [IMP] Add the possibility to specify a validation rule on the ID category
*       e4b926f 2016-03-15 Laurent Mignon (ACSONE) [IMP] Add dummy tests
*       c5f6a07 2016-03-15 Laurent Mignon (ACSONE) [IMP] Update to latests OCA rules
*       7958968 2016-03-15 Laurent Mignon (ACSONE) [MIG] Rename chricar_partner_id_number after extat from the CampToCamp repository

and if you look here https://github.com/OCA/partner-contact/commits/10.0?after=f7ec110676a490448baf08c9820cc35a3643c610+34&path%5B%5D=partner_identification is the same.
v10 has just this piece of history.... and as Pedro said: the old history is on some other branch.

pedrobaeza · 2018-02-26T08:25:44Z

I think we can let it as it. This was more a curiosity than a real thing to be taken care of.

simahawk · 2018-02-26T08:29:46Z

ok, I'll adapt fake models for tests and squash

simahawk · 2018-02-26T08:45:33Z

done. I also replaced svg license image w/ png

yelizariev · 2018-10-09T13:28:52Z

partner_identification/models/res_partner.py

+
+    @api.multi
+    @api.depends('id_numbers')
+    def _compute_identification(self, field_name, category_code):


Does it really make sense to put api.depends? Will it work when we use it via lambda?

compute=lambda s: s._compute_identification( 'social_security', 'SSN', ),

lmignon and others added 9 commits November 29, 2017 14:52

[IMP] Rename partner_identifiers -> partner_identification

cdf122c

[FIX] partner_identification: prevent integrity error on delete ID

05b2183

[ADD] partner_identification: sales_team dep

6d69f90

[FIX] partner_identification: pylint

87fe6fc

[IMP] partner_identification: Add context override (OCA#373)

c74e8a2

Allow for context override of validations using ``id_no_validate``

[FIX] partner_identification: Infinite loop in search (OCA#436)

ac241f4

OCA Transbot updated translations from Transifex

8a1ac1b

simahawk mentioned this pull request Nov 29, 2017

Migration to version 11.0 #482

Closed

53 tasks

yvaucher approved these changes Nov 29, 2017

View reviewed changes

pedrobaeza added this to the 11.0 milestone Nov 29, 2017

elicoidal approved these changes Nov 30, 2017

View reviewed changes

lmignon reviewed Nov 30, 2017

View reviewed changes

simahawk mentioned this pull request Dec 1, 2017

[11.0] mig partner contact in several companies #507

Merged

simahawk added 2 commits February 26, 2018 09:43

[11.0][MIG] partner_identification

62bc898

partner_identification: fix/imp tests on res.partner

a49ae7e

simahawk force-pushed the 11-mig-partner_identification branch from a03bc1e to a49ae7e Compare February 26, 2018 08:44

grindtildeath approved these changes Feb 26, 2018

View reviewed changes

jjscarafia approved these changes May 18, 2018

View reviewed changes

pedrobaeza merged commit 12453c4 into OCA:11.0 May 18, 2018

yelizariev reviewed Oct 9, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] partner_identification #526

[11.0][MIG] partner_identification #526

simahawk commented Nov 29, 2017 •

edited

Loading

yvaucher left a comment

yvaucher Nov 29, 2017

yvaucher Nov 29, 2017

elicoidal left a comment

elicoidal Nov 30, 2017

simahawk Nov 30, 2017

elicoidal Nov 30, 2017

simahawk Nov 30, 2017

pedrobaeza Nov 30, 2017

lmignon Nov 30, 2017

simahawk Nov 30, 2017

lmignon Nov 30, 2017

simahawk Nov 30, 2017

yajo commented Dec 1, 2017

pedrobaeza commented Dec 1, 2017

yajo commented Dec 1, 2017

pedrobaeza commented Dec 1, 2017

simahawk commented Dec 1, 2017

grindtildeath commented Feb 23, 2018

simahawk commented Feb 26, 2018 •

edited

Loading

pedrobaeza commented Feb 26, 2018

simahawk commented Feb 26, 2018

simahawk commented Feb 26, 2018 •

edited

Loading

yelizariev Oct 9, 2018

		@@ -1,3 +1,4 @@
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg

[11.0][MIG] partner_identification #526

[11.0][MIG] partner_identification #526

Conversation

simahawk commented Nov 29, 2017 • edited Loading

yvaucher left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Dec 1, 2017

pedrobaeza commented Dec 1, 2017

yajo commented Dec 1, 2017

pedrobaeza commented Dec 1, 2017

simahawk commented Dec 1, 2017

grindtildeath commented Feb 23, 2018

simahawk commented Feb 26, 2018 • edited Loading

pedrobaeza commented Feb 26, 2018

simahawk commented Feb 26, 2018

simahawk commented Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

simahawk commented Nov 29, 2017 •

edited

Loading

simahawk commented Feb 26, 2018 •

edited

Loading

simahawk commented Feb 26, 2018 •

edited

Loading