Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] database_cleanup: preserve spaces in quoted identifiers #2648

Merged
merged 1 commit into from
Dec 24, 2023
Merged

[15.0][FIX] database_cleanup: preserve spaces in quoted identifiers #2648

merged 1 commit into from
Dec 24, 2023

Conversation

StefanRijnhart
Copy link
Member

Port of #2645

@StefanRijnhart StefanRijnhart added this to the 15.0 milestone Jun 5, 2023
@hbrunn
Copy link
Member

hbrunn commented Dec 23, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@hbrunn The rebase process failed, because command git push --force StefanRijnhart tmp-pr-2648:15.0-database_cleanup-fix_column_names_with_spaces failed with output:

To https://github.com/StefanRijnhart/server-tools
 ! [remote rejected]     tmp-pr-2648 -> 15.0-database_cleanup-fix_column_names_with_spaces (permission denied)
error: failed to push some refs to 'https://***@github.com/StefanRijnhart/server-tools'

@StefanRijnhart StefanRijnhart force-pushed the 15.0-database_cleanup-fix_column_names_with_spaces branch from d86b306 to ae0fc4f Compare December 24, 2023 11:09
@StefanRijnhart
Copy link
Member Author

@hbrunn Rebase done.

@hbrunn
Copy link
Member

hbrunn commented Dec 24, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2648-by-hbrunn-bump-minor, awaiting test results.

@hbrunn hbrunn mentioned this pull request Dec 24, 2023
Merged
@OCA-git-bot OCA-git-bot merged commit a491a0b into OCA:15.0 Dec 24, 2023
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3853d8e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@hbrunn hbrunn hbrunn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@StefanRijnhart @hbrunn @OCA-git-bot @legalsylvain