[16.0][MIG] database_cleanup: Migration to 16.0 #2684

miikanissi · 2023-07-25T22:25:58Z

Original PR author seems to be unavailable at #2473

This PR continues the progress made in that and includes a cherry pick to fix tests

bealdav

LGTM

I've tested to manually add an ir.model.data and db_cleanup allow to purge nicely

Thanks for this PR

hparfr · 2023-09-19T16:16:59Z

database_cleanup/models/purge_modules.py

+        ((modules - installed) + (modules - installed).downstream_dependencies()).write(
+            {"state": "to remove"}
+        )
+        installed.button_immediate_uninstall()


this code is complex and not obvious about the intent.

If I read correctly, modules not in installed, to upgrade (filtered here) and uninstallable, installed, to remove (default argument of downstream_dependencies) are excluded.
So it let: uninstalled to remove, to install. Is it expected ?

Plus, it looks like this code can be shorter if it use the right exclude_filter of modules.downstream_dependencies().

@miikanissi Any comment on above question?

I asked to add this in the previous PR: hbrunn@08c5df6

That's because in v16 a test was added in this function that raises for modules that are not installed.

[cut some nonsense I wrote before]

robyf70

LGTM

robyf70

LGTM

ChrisOForgeFlow · 2023-10-27T21:23:06Z

/ocabot rebase

OCA-git-bot · 2023-10-27T21:23:15Z

@ChrisOForgeFlow The rebase process failed, because command git merge tmp-pr-2684 failed with output:

Auto-merging .github/workflows/test.yml
CONFLICT (content): Merge conflict in .github/workflows/test.yml
Auto-merging .copier-answers.yml
Automatic merge failed; fix conflicts and then commit the result.

ChrisOForgeFlow · 2023-10-27T21:25:09Z

@miikanissi Can you rebase and fix conflicts, thank you in advance

avoid ''NoneType' object has no attribute 'exists'' error when purging models fix my change guewen.baconnier@camptocamp.com-20140203103254-v1mzu2uib047xb9h, wrong lines replaced...

raw SQL query (but never read afterwards). Workaround for lp:1277899 [FIX] Preserve dangling workflow table which is in use [RFR] Group models per table when detecting columns to purge to prevent problems with models sharing the same table [ADD] Allow purging of dangling data entries [FIX] Data purging now working [IMP] Docstrings [FIX] Label [FIX] Catch attempt to unlink field from nonexisting model [RFR] Flake8

[CHG] database_cleanup: move description to README.rst

[IMP] order wizard lines by name [IMP] deal with modules whose models can't be loaded [IMP] double quotes for docstring [FIX] use exists query instead of huge in list [IMP] hide unnecessary buttons in wizard II [IMP] readability [FIX] cope with purging nonexisting models

[IMP] adaptto upstream changes

[ADD] test purging modules [ADD] test purging tables

Fixes #505

[FIX] database_cleanup reloads the registry which has weird side effects during testing. Take care database_cleanup's tests don't mess up the following tests

* [FIX] database_cleanup: Isolate build * Isolate `database_cleanup` into its own build in Travis file to fix #689 * [FIX] database_cleanup: Remove KeyError assertion * Remove KeyError assertion in tests due to PR in comment being merged

* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties

Using new base model inheritance.

[FIX] don't try to uninstall uninstalled modules [DEL] weird code [FIX] actually cleanup where we can

database_cleanup/tests/common.py

database_cleanup/models/purge_modules.py

hbrunn · 2023-12-24T11:42:56Z

please also include #2648 here

No need to rollback here as TransactionCase does a safe rollback.

Needed for purging payment providers which recompute module_state

miikanissi · 2023-12-28T23:02:35Z

please also include #2648 here

Included and rebased. Good to go?

hbrunn · 2023-12-28T23:49:29Z

Thanks for the followup.

Still need to deal with the last test failure

I'd suggest to patch away self.env.cr.commit in the test using self.patch

Or maybe we don't need the commit in v16?

miikanissi · 2023-12-29T03:36:24Z

I'm not very familiar with the unittest mock objects. I'd need help to figure out the patch.

hbrunn · 2023-12-29T04:34:29Z

off the top of my head: self.patch(self.env.cr, 'commit', lambda: None)

miikanissi · 2023-12-29T07:43:14Z

off the top of my head: self.patch(self.env.cr, 'commit', lambda: None)

@hbrunn That patch did work correctly and allowed the test to continue. However as stated here, not committing seems to cause the ORM to hang indefinitely.

However I cherry picked 00cdfb2 from 15.0 which improved on the tests

pedrobaeza · 2023-12-29T09:11:09Z

/ocabot merge nobump

OCA-git-bot · 2023-12-29T09:11:32Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2684-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-12-29T09:17:16Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-12-29T09:17:16Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-12-29T09:19:49Z

Congratulations, your PR was merged at c963e27. Thanks a lot for contributing to OCA. ❤️

pedrobaeza · 2023-12-29T09:21:18Z

/ocabot migration database_cleanup

dariodelzozzo mentioned this pull request Sep 6, 2023

[16.0][MIG] database_cleanup #2699

Closed

bealdav approved these changes Sep 19, 2023

View reviewed changes

hparfr reviewed Sep 19, 2023

View reviewed changes

robyf70 reviewed Oct 26, 2023

View reviewed changes

robyf70 approved these changes Oct 26, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 26, 2023

Stefan Rijnhart and others added 21 commits October 30, 2023 13:35

[ADD] Database cleanup module

cad5ae1

remove relations when purging models

801a5d4

avoid ''NoneType' object has no attribute 'exists'' error when purging models fix my change guewen.baconnier@camptocamp.com-20140203103254-v1mzu2uib047xb9h, wrong lines replaced...

[CHG] Migration to 8.0

e5e76d0

[CHG] database_cleanup: move description to README.rst

Missing templates and translations added

b4e1e4d

[ADD] allow to clean up menus

5b31147

[IMP] allow to select lines to purge in a tree view

cf5785b

[IMP] adaptto upstream changes

[ADD] migrate database_cleanup

617a991

[ADD] test purging modules [ADD] test purging tables

[RFR] Explicit access rights so that tests can run

6e27c30

Fixes #505

[FIX] purge uninstalled uninstallable modules instead of deleting

180e598

[FIX] database_cleanup reloads the registry which has weird side effects during testing. Take care database_cleanup's tests don't mess up the following tests

OCA Transbot updated translations from Transifex

39d97e0

[IMP] call the button handler to also purge reverse dependencies

5bba296

[FIX] don't crash if an xmlid refers to a nonexisting field (#559)

e3b8fda

[FIX] clean database menus was proposing good menus to purge (#562)

3778616

fixes #587

3953779

[FIX] database_cleanup: Fix test (#612)

808cdaa

[MIG] database_cleanup: Migration to version 10.0

73cb3aa

Using new base model inheritance.

[FIX] really uninstall modules and avoid a crash on cached data

8d03304

[FIX] don't try to uninstall uninstalled modules [DEL] weird code [FIX] actually cleanup where we can

hbrunn requested changes Dec 23, 2023

View reviewed changes

database_cleanup/tests/common.py Outdated Show resolved Hide resolved

OCA-git-bot removed the approved label Dec 23, 2023

hbrunn reviewed Dec 23, 2023

View reviewed changes

database_cleanup/models/purge_modules.py Outdated Show resolved Hide resolved

miikanissi and others added 4 commits December 28, 2023 17:59

[IMP] database_cleanup: Readability of modules to remove

8d364c3

[FIX] database_cleanup: TransactionCase already does rollback

62885e3

No need to rollback here as TransactionCase does a safe rollback.

[IMP] database_cleanup: Unlink with new cursor

0d2fbc3

Needed for purging payment providers which recompute module_state

[FIX] database_cleanup: preserve spaces in quoted identifiers

f80f43c

[IMP] database_cleanup: improve tests

e791803

hbrunn approved these changes Dec 29, 2023

View reviewed changes

OCA-git-bot added the approved label Dec 29, 2023

pedrobaeza mentioned this pull request Dec 29, 2023

[16.0][MIG] database_cleanup: Migration to 16.0 #2473

Closed

OCA-git-bot added bot is merging ⏳ ready to merge labels Dec 29, 2023

OCA-git-bot merged commit 3594697 into OCA:16.0 Dec 29, 2023
9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 29, 2023

OCA-git-bot added this to the 16.0 milestone Dec 29, 2023

OCA-git-bot mentioned this pull request Dec 29, 2023

Migration to version 16.0 #2412

Open

33 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] database_cleanup: Migration to 16.0 #2684

[16.0][MIG] database_cleanup: Migration to 16.0 #2684

miikanissi commented Jul 25, 2023

bealdav left a comment

hparfr Sep 19, 2023

robyf70 Oct 25, 2023

hbrunn Dec 23, 2023 •

edited

Loading

robyf70 left a comment

robyf70 left a comment

ChrisOForgeFlow commented Oct 27, 2023

OCA-git-bot commented Oct 27, 2023

ChrisOForgeFlow commented Oct 27, 2023

hbrunn commented Dec 24, 2023

miikanissi commented Dec 28, 2023

hbrunn commented Dec 28, 2023 •

edited

Loading

miikanissi commented Dec 29, 2023

hbrunn commented Dec 29, 2023 •

edited

Loading

miikanissi commented Dec 29, 2023

pedrobaeza commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

pedrobaeza commented Dec 29, 2023

[16.0][MIG] database_cleanup: Migration to 16.0 #2684

[16.0][MIG] database_cleanup: Migration to 16.0 #2684

Conversation

miikanissi commented Jul 25, 2023

bealdav left a comment

Choose a reason for hiding this comment

hparfr Sep 19, 2023

Choose a reason for hiding this comment

robyf70 Oct 25, 2023

Choose a reason for hiding this comment

hbrunn Dec 23, 2023 • edited Loading

Choose a reason for hiding this comment

robyf70 left a comment

Choose a reason for hiding this comment

robyf70 left a comment

Choose a reason for hiding this comment

ChrisOForgeFlow commented Oct 27, 2023

OCA-git-bot commented Oct 27, 2023

ChrisOForgeFlow commented Oct 27, 2023

hbrunn commented Dec 24, 2023

miikanissi commented Dec 28, 2023

hbrunn commented Dec 28, 2023 • edited Loading

miikanissi commented Dec 29, 2023

hbrunn commented Dec 29, 2023 • edited Loading

miikanissi commented Dec 29, 2023

pedrobaeza commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

OCA-git-bot commented Dec 29, 2023

pedrobaeza commented Dec 29, 2023

hbrunn Dec 23, 2023 •

edited

Loading

hbrunn commented Dec 28, 2023 •

edited

Loading

hbrunn commented Dec 29, 2023 •

edited

Loading