[11.0][MIG] stock_available: Migration to 11.0 #405

asaunier · 2018-04-09T07:50:12Z

Based upon PR #353 by @kikopeiro
I have only squashed the "OCA Transbot updated translations from Transifex" commits as suggested by @yvaucher

I have also removed the 2 [MIG] Make modules uninstallable commits.

I have not removed the commented out section in res_config_settings_views.xml as pointed by @gurneyalex Shoud I? Why is this section commented out?

asaunier · 2018-04-10T10:02:12Z

@gurneyalex Since you have approved the original PR #353, do you approve this one wich is the same with a few squashed commits?

Anyone else for a review? Thanks :)

asaunier · 2018-04-13T09:27:57Z

Hi @pedrobaeza !
Could you add the "needs review" label please?
Thanks :)

rousseldenis

Code review. Minor changes.

Could you please also consider commits in 10.0 branch history after the 9th of May 2017 ?

rousseldenis · 2018-04-17T09:06:00Z

stock_available/models/product_template.py

+            for p in product.product_variant_ids:
+                qty = variant_available[p.id]["immediately_usable_qty"]
+                immediately_usable_qty += qty
+                if p.potential_qty > potential_qty:


@asaunier Please use float_compare

rousseldenis · 2018-04-17T09:07:57Z

stock_available/views/res_config_settings_views.xml

+                            </div>
+                        </div>
+
+                        <!--<div>-->


Please remove unneeded comments

jcdrubay · 2018-04-20T03:10:47Z

stock_available/README.rst

+
+By default, this module computes the stock available to promise as the virtual
+stock.
+To take advantage of the additional features, you must which information you


you must define on which

jcdrubay

Very nice module, some comments for very minor requests.

jcdrubay · 2018-04-20T03:13:23Z

stock_available/models/product_product.py

+# Copyright 2016 Sodexis
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from odoo import models, fields, api


Should be alphebetical order also within the line:

from odoo import api, models, fields

jcdrubay · 2018-04-20T03:15:14Z

stock_available/models/product_product.py

+        help="Stock for this Product that can be safely proposed "
+             "for sale to Customers.\n"
+             "The definition of this value can be configured to suit "
+             "your needs")


add a final dot

"your needs."

congdpt

👍 Thanks, but I think you need some points to fix

congdpt · 2018-04-20T03:28:14Z

stock_available/models/__init__.py

+# Copyright 2016 Sodexis
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from . import product_template


You should sort the import lines base on Alphabet

congdpt · 2018-04-20T03:29:23Z

stock_available/models/product_product.py

+# Copyright 2016 Sodexis
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from odoo import models, fields, api


It should be from odoo import api, fields, models

congdpt · 2018-04-20T03:30:45Z

stock_available/models/product_product.py

+
+class ProductProduct(models.Model):
+
+    """Add a field for the stock available to promise.


I think you need split """ and the text to 2 lines, it will be look well

congdpt · 2018-04-20T03:31:44Z

stock_available/models/product_product.py

+    @api.multi
+    @api.depends('virtual_available')
+    def _compute_immediately_usable_qty(self):
+        """No-op implementation of the stock available to promise.


I think you need split """ and the text to 2 lines, it will be look well

congdpt · 2018-04-20T03:32:07Z

stock_available/models/product_product.py

+    @api.multi
+    @api.depends()
+    def _compute_potential_qty(self):
+        """Set potential qty to 0.0 to define the field defintion used by


I think you need split """ and the text to 2 lines, it will be look well

congdpt · 2018-04-20T03:40:40Z

stock_available/models/product_template.py

+
+            if isinstance(product.id, models.NewId):
+                continue
+            immediately_usable_qty = 0.0


I think we need one line before this line and no need a line after this line

congdpt · 2018-04-20T03:41:35Z

stock_available/models/product_template.py

+    @api.multi
+    @api.depends('product_variant_ids.immediately_usable_qty')
+    def _compute_immediately_usable_qty(self):
+        """No-op implementation of the stock available to promise.


I think you need split """ and the text to 2 lines, it will be look well

congdpt · 2018-04-20T03:42:31Z

stock_available/models/product_template.py

+            variants.
+        """
+        res = self._product_available()
+        for tmpl in self.filtered(lambda x: not isinstance(x.id,


If will better like that:

for tmpl in self.filtered( lambda x: not isinstance(x.id, models.NewId)):

congdpt · 2018-04-20T03:43:25Z

stock_available/models/product_template.py

+    @api.multi
+    @api.depends('product_variant_ids.potential_qty')
+    def _compute_potential_qty(self):
+        """Compute the potential as the max of all the variants's potential.


I think you need split """ and the text to 2 lines, it will be look well

congdpt · 2018-04-20T03:44:03Z

stock_available/models/res_config_settings.py

+# Copyright 2016 Sodexis
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from odoo import api, models, fields


It should be from odoo import api, fields, models

tschanzt

Only minor nitpicking otherwise 👍

tschanzt · 2018-04-20T16:33:50Z

stock_available/views/product_template_view.xml

+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). -->
+
+<odoo>
+        <record model="ir.ui.view" id="view_stock_available_form">


indentation is wrong.

tschanzt · 2018-04-20T16:33:56Z

stock_available/views/product_product_view.xml

+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). -->
+
+<odoo>
+        <record model="ir.ui.view" id="product_normal_form_view">


indentation is wrong.

tschanzt · 2018-04-20T16:34:25Z

stock_available/views/res_config_settings_views.xml

+        <field name="model">res.config.settings</field>
+        <field name="inherit_id" ref="stock.res_config_settings_view_form" />
+        <field name="arch" type="xml">
+            <data>


you can drop the data tag.

tschanzt · 2018-04-23T09:26:58Z

stock_available/models/product_template.py

+    def _compute_available_quantities(self):
+        res = self._compute_available_quantities_dict()
+        for product in self:
+            for key, value in res[product.id].iteritems():


iteritems doesn't exist anymore in python3. use items.

asaunier · 2018-04-23T11:05:35Z

@rousseldenis @jcdrubay @congdpt @tschanzt Thanks for reviewing!

I have taken your feedbacks into account and added the commits done in 10.0 since the initial PR #353 was created, 5 months ago.

rousseldenis

Code review. LGTM

pedrobaeza · 2018-04-23T12:24:09Z

I think commit history can be squashed a bit, specially at the beginning where a lot of commits from the same person and corresponding to the initial logic are there.

Generic module to compute the stock quantity available to promise using several implementations. stock_available_immediatly is changed to become the first optional implementation. Cherry pick of commit 0b060f6 from the v7 branch [IMP] stock_available* uses new API [ADD] stock_available_mrp Module to take immediate manufaturing capability into account in the stock quantity available to promise. Conflicts: stock_available/res_config.py [DEL] move stock_available_mrp to __unported__ [ADD] stock_available_sale Take sale quotations into account in the stock quantity available to promise Cherry-picked from 497068f Conflicts: stock_available/res_config.py [DEL] move stock_available_sale to __unported__ [IMP] READMEs and TODOs Cherry-picked from v7 at 8add4be Conflicts: __unported__/stock_available_mrp/__openerp__.py stock_available/__openerp__.py stock_available_immediately/__openerp__.py [IMP] respect product decimal precision odoo/odoo#5512 and odoo-dev/odoo@b3e5a94 makes it clear the standard intends to support decimal precision on the product form.

…uct and product.template, now takes in account variants and correctly displays value. [FLAKE8] Removing duplicate modules and moving README.rst into __unported__ [ADD} location calculations [FIX] typo

not using internal qty_available that seems not to take in consideration reserved quants. [ADD] Tests

Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move). Fixes #79 Remove loop and use correct decorator Restore the features of stock_available_immediately The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly. This commit also takes care to respect the distinction between templates and variants, so it should fix #73 too. Restore the qty avail. to promise on variant treeview PEP8

* fix the dependencies for the computed field * use api.multi instead of api.one to avoid calling super()._immediately_usable_qty in a loop (this improves perfs on a tree view display)

There are cases where we dot NOT want to simply sum the quantities of all the variants. For example when dealing with manufacturing capacities, we may have to chose between variants because we can't make ALL of them with the same components. So instead of a simple non-modular implementation, we'll let each module define his own implementation of how to compute the product template's quantity available for sale. Conflicts: stock_available/__openerp__.py stock_available_immediately/__openerp__.py

…ch field use to compute potential

[CHG] improve code regarding code review [ADD] add test [CHG] optimize stock computation by avoiding to call useless compute

… related unit test Increase version number of the module

asaunier · 2018-04-23T13:00:35Z

@pedrobaeza I have just rebased the PR squashing consecutive commits from the same contributors together. The PR now has 22 commits instead of 39.

pedrobaeza · 2018-04-23T15:19:27Z

Great, thanks!

This was referenced Apr 9, 2018

[11.0][MIG] stock_available: Migration to 11.0 #353

Closed

Migration to version 11.0 #343

Closed

gurneyalex added the needs review label Apr 17, 2018

gurneyalex approved these changes Apr 17, 2018

View reviewed changes

rousseldenis requested changes Apr 17, 2018

View reviewed changes

jcdrubay reviewed Apr 20, 2018

View reviewed changes

congdpt suggested changes Apr 20, 2018

View reviewed changes

tschanzt reviewed Apr 20, 2018

View reviewed changes

tschanzt suggested changes Apr 23, 2018

View reviewed changes

rousseldenis approved these changes Apr 23, 2018

View reviewed changes

tschanzt approved these changes Apr 23, 2018

View reviewed changes

Lionel Sausin (Numérigraphe) and others added 14 commits April 23, 2018 14:54

[FIX] corrected calculation of immediately_usable_qty on product.prod…

7624343

…uct and product.template, now takes in account variants and correctly displays value. [FLAKE8] Removing duplicate modules and moving README.rst into __unported__ [ADD} location calculations [FIX] typo

[FIX] searching on products, leaving full calculations

0607d92

not using internal qty_available that seems not to take in consideration reserved quants. [ADD] Tests

[FIX] stock_available : update sublocations computation

dbd89ff

OCA Transbot updated translations from Transifex

40e1cf2

[UPD] prefix versions with 8.0

6e03738

[FIX] stock_available: Fix manifest

28a0c76

[9.0][PORT] Stock available

196443d

product_available improvements

db96d77

* fix the dependencies for the computed field * use api.multi instead of api.one to avoid calling super()._immediately_usable_qty in a loop (this improves perfs on a tree view display)

stock_available / stock_available_mrp : add possibility to choose whi…

03cf1c4

…ch field use to compute potential

bom stock: small improvements and add test for field choice

d06b691

[FIX] remove en.po that was erroneously created by transbot

2caf388

pedrobaeza and others added 8 commits April 23, 2018 14:54

[MIG] Rename manifest files

bfbd328

[10.0][MIG] stock_available & stock_available_immediately (#219)

2572282

[10.0]stock_available: improve computation performance

361b79e

[CHG] improve code regarding code review [ADD] add test [CHG] optimize stock computation by avoiding to call useless compute

[MIG] stock_available_sale: Migration to 10.0

9810518

[FIX] stock_available: Some affectations

0c87a83

[ADD] Add search function for immediately_usable_qty computed field +…

dcc2e22

… related unit test Increase version number of the module

[MIG] stock_available: Migration to 11.0

cc3ff4c

[FIX] Improve migration to 11.0

225e584

pedrobaeza merged commit fa3791e into OCA:11.0 Apr 23, 2018

asaunier deleted the 11.0-mig-stock_available branch April 23, 2018 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] stock_available: Migration to 11.0 #405

[11.0][MIG] stock_available: Migration to 11.0 #405

asaunier commented Apr 9, 2018 •

edited

Loading

asaunier commented Apr 10, 2018

asaunier commented Apr 13, 2018

rousseldenis left a comment

rousseldenis Apr 17, 2018

rousseldenis Apr 17, 2018

jcdrubay Apr 20, 2018 •

edited

Loading

jcdrubay left a comment

jcdrubay Apr 20, 2018

jcdrubay Apr 20, 2018

congdpt left a comment

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

congdpt Apr 20, 2018

tschanzt left a comment

tschanzt Apr 20, 2018

tschanzt Apr 20, 2018

tschanzt Apr 20, 2018

tschanzt Apr 23, 2018

asaunier commented Apr 23, 2018

rousseldenis left a comment

pedrobaeza commented Apr 23, 2018

asaunier commented Apr 23, 2018 •

edited

Loading

pedrobaeza commented Apr 23, 2018


		class ProductProduct(models.Model):

		"""Add a field for the stock available to promise.

[11.0][MIG] stock_available: Migration to 11.0 #405

[11.0][MIG] stock_available: Migration to 11.0 #405

Conversation

asaunier commented Apr 9, 2018 • edited Loading

asaunier commented Apr 10, 2018

asaunier commented Apr 13, 2018

rousseldenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jcdrubay Apr 20, 2018 • edited Loading

Choose a reason for hiding this comment

jcdrubay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

congdpt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschanzt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asaunier commented Apr 23, 2018

rousseldenis left a comment

Choose a reason for hiding this comment

pedrobaeza commented Apr 23, 2018

asaunier commented Apr 23, 2018 • edited Loading

pedrobaeza commented Apr 23, 2018

asaunier commented Apr 9, 2018 •

edited

Loading

jcdrubay Apr 20, 2018 •

edited

Loading

asaunier commented Apr 23, 2018 •

edited

Loading