[13.0][FIX] stock_picking_import_serial_number: Lot overwriting #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import wizard presents an option to "Overwrite Serial", which should take all serials from the XLSX, and unconditionally write them into existing SMLs. However, the condition was not well formed, and so each XLSX line would write to the same SML - effectively only importing the *last* XLSX line into only the *first* SML.
|
Hi @sergio-teruel, |
ryanc-me
changed the title
pedrobaeza
reviewed
Aug 10, 2022
| @@ -78,16 +78,20 @@ def _import_serial_number(self, xl_sheet, stock_move_lines, picking): | |||
| products = self.env["product.product"].search( | |||
| [(self.sn_search_product_by_field, "in", list(product_file_set))] | |||
| ) | |||
| sml_done = self.env["stock.move.line"] | |||
There was a problem hiding this comment.
Suggested change
| sml_done = self.env["stock.move.line"] | |
| sml_done = set() |
| for item in serial_list: | ||
| product = products.filtered( | ||
| lambda p: p[self.sn_search_product_by_field] == item[0] | ||
| ) | ||
| if picking.picking_type_id.show_reserved: | ||
| smls = stock_move_lines.filtered(lambda ln: ln.product_id == product) | ||
| for sml in smls: | ||
| if not sml.lot_name or self.overwrite_serial: | ||
| lot_ok = not sml.lot_name | ||
| overwrite_ok = self.overwrite_serial and sml not in sml_done |
There was a problem hiding this comment.
Suggested change
| overwrite_ok = self.overwrite_serial and sml not in sml_done | |
| overwrite_ok = self.overwrite_serial and sml.id not in sml_done |
| sml.lot_name = item[1] | ||
| sml.qty_done = 1.0 | ||
| sml_done += sml |
There was a problem hiding this comment.
Suggested change
| sml_done += sml | |
| sml_done.add(sml.id) |
|
@ryanc-me Thanks...I will correct it in the next commit that will also allow selecting serial numbers in internal and ougoing operations. I will ping you to review |
|
@ryanc-me @sergio-teruel What's the status of this ? |
|
@rousseldenis the author's PR #1065 supersedes this one |
|
Superseded by #1065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import wizard presents an option to "Overwrite Serial", which should
take all serials from the XLSX, and unconditionally write them into existing
SMLs.
However, the condition was not well formed, and so each XLSX line would
write to the same SML - effectively only importing the last XLSX line
into only the first SML.