Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][IMP] stock_picking_import_serial_number: Allow import S/N from file in internal and outgoing operations #1065

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Aug 10, 2022

cc @Tecnativa TT38516

ping @pedrobaeza @chienandalu

I have some doubt regarding internal pickings and ougoing...
At the moment, if the lot exists and not in sml reserved, the stock move line is created, but I don't check if there is availability...

@ryanc-me #1062 fixed here

@sergio-teruel sergio-teruel force-pushed the 13.0-IMP-stock_picking_import_serial_number-use-file-for-internal-outgoing branch from 087f3e2 to 670b70e Compare August 10, 2022 16:33
@ryanc-me
Copy link
Contributor

@sergio-teruel Looks good! I hope you don't mind my feedback below.

You make a good point regarding the availability check. Maybe one of these would work:

  1. If the stock is not available, display a pop-up wizard showing the unavailable lines, and offering to Confirm or Cancel
  2. Add an option to the initial import wizard (or company settings) so the user can choose whether to consider/ignore stock (e.g. "Check Availability" boolean field)
  3. Ignore availability all together - this is an explicit import, much like entering SMLs manually via the detailed operations tab, so perhaps the user intent is to "import exactly what I say"?

Lastly, I think the availability-check logic should apply to incoming transfers also: If we have an inter-warehouse receipt, the picking type usage may be incoming, but the source location could actually be tracking stock (like WH/Stock -> Transit -> WH2/Stock, the last step is a receipt but we do know what stock is in Transit)

Maybe the location_src_id.usage field is a good check instead? (i.e., ignore availability for any "Virtual" locations)

… lots availability for internal and outgoing operations
@sergio-teruel sergio-teruel changed the title [13.0][IMP] stock_picking_import_serial_number: Allow import S/N from file in internal and outgoing operations [WIP][13.0][IMP] stock_picking_import_serial_number: Allow import S/N from file in internal and outgoing operations Aug 14, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 18, 2022
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 20, 2022
@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 20, 2022
@pedrobaeza pedrobaeza changed the title [WIP][13.0][IMP] stock_picking_import_serial_number: Allow import S/N from file in internal and outgoing operations [13.0][IMP] stock_picking_import_serial_number: Allow import S/N from file in internal and outgoing operations Dec 20, 2022
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's finish with this:

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1065-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eb9be10 into OCA:13.0 Dec 20, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c151420. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants