-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][IMP] stock_picking_import_serial_number: Allow import S/N from file in internal and outgoing operations #1065
Conversation
…in internal and outgoing operations TT38516
087f3e2
to
670b70e
Compare
@sergio-teruel Looks good! I hope you don't mind my feedback below. You make a good point regarding the availability check. Maybe one of these would work:
Lastly, I think the availability-check logic should apply to incoming transfers also: If we have an inter-warehouse receipt, the picking type usage may be Maybe the |
… lots availability for internal and outgoing operations
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's finish with this:
/ocabot merge major
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at c151420. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT38516
ping @pedrobaeza @chienandalu
I have some doubt regarding internal pickings and ougoing...
At the moment, if the lot exists and not in sml reserved, the stock move line is created, but I don't check if there is availability...
@ryanc-me #1062 fixed here