Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] stock_picking_import_serial_number: Migration to 15.0 #1064

Closed

Conversation

ryanc-me
Copy link
Contributor

@ryanc-me ryanc-me commented Aug 9, 2022

No changes required

@rousseldenis
Copy link
Contributor

@ryanc-me Still WIP ?

@ryanc-me
Copy link
Contributor Author

@rousseldenis it's working, but the module author is adding some fixes/improvements to the 13.0 branch (#1065). I'm waiting for that PR so I can include the fixes here too

sergio-teruel and others added 7 commits October 29, 2022 00:05
[UPD] Update stock_picking_import_serial_number.pot
You can't use a static assignation in kw args, and less the empty
string, which is assigned as is on the char fields (and being different
from NULL values).
Don't pass `default_code` in vals if no reference is provided, for
letting other modules to work properly in integration tests like
`product_code_mandatory` + `product_sequence`.
@ryanc-me ryanc-me force-pushed the 15.0-mig-stock_picking_import_serial_number branch from a0cc67c to 423ff28 Compare October 29, 2022 00:06
@ryanc-me
Copy link
Contributor Author

@rousseldenis @sebalix would also very much appreciate a review here :)

Please see #1063 (comment)

@ryanc-me ryanc-me force-pushed the 15.0-mig-stock_picking_import_serial_number branch from 423ff28 to a23c82f Compare October 29, 2022 00:14
@ryanc-me ryanc-me marked this pull request as ready for review October 29, 2022 00:18
@sebalix
Copy link
Contributor

sebalix commented Nov 3, 2022

/ocabot migration stock_picking_import_serial_number

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 3, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 3, 2022
66 tasks
@@ -3,7 +3,7 @@
{
"name": "Stock Picking Import Serial Numbers",
"summary": "Import S/N from excel file for incoming pickings",
"version": "14.0.1.0.2",
"version": "15.0.1.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reset to "15.0.1.0.0" ?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 21, 2023
@pedrobaeza
Copy link
Member

@ryanc-me can you perform the change to merge this?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 28, 2023
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test import S/N in receive 👍

@pedrobaeza
Copy link
Member

Superseded by #1392 as no answer.

@pedrobaeza pedrobaeza closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants