-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] stock_picking_import_serial_number: Migration to 15.0 #1064
[MIG] stock_picking_import_serial_number: Migration to 15.0 #1064
Conversation
@ryanc-me Still WIP ? |
@rousseldenis it's working, but the module author is adding some fixes/improvements to the 13.0 branch (#1065). I'm waiting for that PR so I can include the fixes here too |
[UPD] Update stock_picking_import_serial_number.pot
You can't use a static assignation in kw args, and less the empty string, which is assigned as is on the char fields (and being different from NULL values).
Don't pass `default_code` in vals if no reference is provided, for letting other modules to work properly in integration tests like `product_code_mandatory` + `product_sequence`.
a0cc67c
to
423ff28
Compare
@rousseldenis @sebalix would also very much appreciate a review here :) Please see #1063 (comment) |
423ff28
to
a23c82f
Compare
/ocabot migration stock_picking_import_serial_number |
@@ -3,7 +3,7 @@ | |||
{ | |||
"name": "Stock Picking Import Serial Numbers", | |||
"summary": "Import S/N from excel file for incoming pickings", | |||
"version": "14.0.1.0.2", | |||
"version": "15.0.1.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reset to "15.0.1.0.0" ?
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@ryanc-me can you perform the change to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Test import S/N in receive 👍
Superseded by #1392 as no answer. |
No changes required