[MIG] stock_picking_import_serial_number: Migration to 14.0 #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration stock_picking_import_serial_number |
sebalix
reviewed
Sep 1, 2022
ryanc-me
force-pushed
the
14.0-mig-stock_picking_import_serial_number
branch
2 times, most recently
from
4a80f4e
to
8850d27
Compare
|
@sebalix Ready to go 👍 |
sebalix
approved these changes
Sep 16, 2022
[UPD] Update stock_picking_import_serial_number.pot
You can't use a static assignation in kw args, and less the empty string, which is assigned as is on the char fields (and being different from NULL values).
Don't pass `default_code` in vals if no reference is provided, for letting other modules to work properly in integration tests like `product_code_mandatory` + `product_sequence`.
ryanc-me
force-pushed
the
14.0-mig-stock_picking_import_serial_number
branch
from
8850d27
to
41649bc
Compare
|
@sebalix @rousseldenis could you guys please re-review? This is a 14.0 migration of the current 13.0 version. Note that there is a known edge-case bug in that version, with an in-progress PR #1065. @pedrobaeza is it okay to migrate as-is like this? Once #1065 is merged I can create a PR to forward-port it (unless that's handled by OCA in the background). |
|
Yes, it's reasonable. |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 88b9eac. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes in logic. The only addition is
ir.model.access.csv, which is now required for transient models.