Remove rules #24
Merged
Remove rules #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Gin requires Claro).
Remove custom_theme dependency and instead set Gin as default theme
* Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
agger-magenta
approved these changes
Nov 5, 2021
|
I get that the main thing is about the rules dependency. But isn't there something else going on in the PR? |
Collaborator
Author
|
@lats1 True, I have looked over the changes which are from a previous commit as the branch for this PR was made from main branch. Long story short these changes are present in Main branch. We should set develop as default branch I reckon. |
lats1
suggested changes
Nov 5, 2021
Collaborator
Author
|
Change as per request to the latest version of the Forløb module with Rules removed as dependency. |
lats1
approved these changes
Nov 5, 2021
madsnorgaard
added a commit
that referenced
this pull request
Nov 5, 2021
* Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role * Remove rules modules (#23) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Remove Rules modules Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Remove rules (#24) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Remove rules branch * No installation of Rules modules * Update Forløb module version Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
madsnorgaard
added a commit
that referenced
this pull request
Nov 29, 2021
* Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role * [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation * Remove rules modules (#23) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Remove Rules modules Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Remove rules (#24) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Remove rules branch * No installation of Rules modules * Update Forløb module version Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Add patch to dynamic entity reference module (#27) * Add patch to dynamic entity reference module * Add link to patch comment Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
madsnorgaard
added a commit
that referenced
this pull request
Dec 16, 2021
* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Develop into main (#25) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role * Remove rules modules (#23) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Remove Rules modules Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Remove rules (#24) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Remove rules branch * No installation of Rules modules * Update Forløb module version Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Develop (#28) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role * [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation * Remove rules modules (#23) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Remove Rules modules Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Remove rules (#24) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Remove rules branch * No installation of Rules modules * Update Forløb module version Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Add patch to dynamic entity reference module (#27) * Add patch to dynamic entity reference module * Add link to patch comment Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Added changes related to Drupal 9 compatibility * Upgrade os2forms/os2forms_forloeb to latest version Co-authored-by: Mads Nørgaard <madsnorgaard@live.dk> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: mn <mn@magenta-aps.dk>
madsnorgaard
added a commit
that referenced
this pull request
Dec 20, 2021
* Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role * [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation * Remove rules modules (#23) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Remove Rules modules Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Remove rules (#24) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Remove rules branch * No installation of Rules modules * Update Forløb module version Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Add patch to dynamic entity reference module (#27) * Add patch to dynamic entity reference module * Add link to patch comment * Updated os2forms/os2forms and os2forms/os2forms_forloeb (#29) * Added changes related to Drupal 9 compatibility (#30) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Develop into main (#25) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role * Remove rules modules (#23) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Remove Rules modules Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Remove rules (#24) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Remove rules branch * No installation of Rules modules * Update Forløb module version Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Develop (#28) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role * [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation * Remove rules modules (#23) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Remove Rules modules Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Remove rules (#24) * Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro). * Merge Develop into Main (#21) * Changing webform permissions for flowdesigner * [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted * [#44224] Changed permission to allow page to be added through the 'references'-tab * [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside * Add almost copy of Leder role as Borger role Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Remove rules branch * No installation of Rules modules * Update Forløb module version Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> * Add patch to dynamic entity reference module (#27) * Add patch to dynamic entity reference module * Add link to patch comment Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Added changes related to Drupal 9 compatibility * Upgrade os2forms/os2forms_forloeb to latest version Co-authored-by: Mads Nørgaard <madsnorgaard@live.dk> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: mn <mn@magenta-aps.dk> * Downgrade os2forms/os2forms (#31) * Update composer.json Upgrade to latest version of OS2forms med Forløb 1.9.0 Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: Mikkel Ricky <rimi@aarhus.dk> Co-authored-by: Andriyun <andriy.yun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by OS2Forms/os2forms_forloeb#89
We will need to alter the version to the newest release of the Forløbs module:
https://github.com/OS2Forms/os2forms_forloeb_profile/pull/24/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R22
This line should be updated to the newest release tag of the module once the PR is merged