Skip to content

Conversation

@madsnorgaard
Copy link
Collaborator

@madsnorgaard madsnorgaard commented Nov 17, 2021

Tested locally and it works as we want it to on build.
Patch is applied and error is rectified on install.

@madsnorgaard madsnorgaard requested a review from lats1 November 17, 2021 13:50
Copy link
Collaborator

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A single suggestion to consider.

@madsnorgaard madsnorgaard merged commit ae7c694 into develop Nov 26, 2021
madsnorgaard added a commit that referenced this pull request Nov 29, 2021
* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Add patch to dynamic entity reference module (#27)

* Add patch to dynamic entity reference module

* Add link to patch comment

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
madsnorgaard added a commit that referenced this pull request Dec 16, 2021
* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Develop into main (#25)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Develop (#28)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Add patch to dynamic entity reference module (#27)

* Add patch to dynamic entity reference module

* Add link to patch comment

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Added changes related to Drupal 9 compatibility

* Upgrade os2forms/os2forms_forloeb to latest version

Co-authored-by: Mads Nørgaard <madsnorgaard@live.dk>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: mn <mn@magenta-aps.dk>
madsnorgaard added a commit that referenced this pull request Dec 20, 2021
* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Add patch to dynamic entity reference module (#27)

* Add patch to dynamic entity reference module

* Add link to patch comment

* Updated os2forms/os2forms and os2forms/os2forms_forloeb (#29)

* Added changes related to Drupal 9 compatibility (#30)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Develop into main (#25)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Develop (#28)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Add patch to dynamic entity reference module (#27)

* Add patch to dynamic entity reference module

* Add link to patch comment

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Added changes related to Drupal 9 compatibility

* Upgrade os2forms/os2forms_forloeb to latest version

Co-authored-by: Mads Nørgaard <madsnorgaard@live.dk>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: mn <mn@magenta-aps.dk>

* Downgrade os2forms/os2forms (#31)

* Update composer.json

Upgrade to latest version of OS2forms med Forløb 1.9.0

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Andriyun <andriy.yun@gmail.com>
@madsnorgaard madsnorgaard deleted the 46801_patch_dynamic_entity_reference_module branch January 21, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants