Skip to content

Conversation

@rimi-itk
Copy link
Collaborator

"os2forms/os2forms": "^3.0" and "os2forms/os2forms_forloeb": "^1.8" conflict when running composer install.

@rimi-itk rimi-itk changed the base branch from main to develop December 16, 2021 13:42
@lats1 lats1 requested a review from madsnorgaard December 16, 2021 13:44
@madsnorgaard
Copy link
Collaborator

Jeg mener denne håndtering tager sig af alles interesser for nu.

@rimi-itk rimi-itk force-pushed the feature/os2forms-2.8 branch from 0612b5d to 1218d6c Compare December 17, 2021 10:43
@rimi-itk
Copy link
Collaborator Author

Merger du så til develop, @madsnorgaard?

@madsnorgaard madsnorgaard merged commit bc18b1c into OS2Forms:develop Dec 17, 2021
@madsnorgaard
Copy link
Collaborator

Vi laver release når denne PR er merged: #32

Der er en enkelt konflikt.

@rimi-itk
Copy link
Collaborator Author

rimi-itk commented Dec 17, 2021

Hvem forventes at løses konflikten? Det er ret enkelt og nogle gange forstår jeg ikke hvorfor git ikke selv kan finde ud af det.

@rimi-itk rimi-itk deleted the feature/os2forms-2.8 branch December 17, 2021 13:46
@madsnorgaard
Copy link
Collaborator

Fremadrettet tænker jeg at vi håndterer konflikter som opretter af PR? Men du har ret, det er en triviel opgave. Mener også at Gitlab håndterer den slags ved at tjekke efter enhver fletning til base branchen.

madsnorgaard added a commit that referenced this pull request Dec 20, 2021
* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Add patch to dynamic entity reference module (#27)

* Add patch to dynamic entity reference module

* Add link to patch comment

* Updated os2forms/os2forms and os2forms/os2forms_forloeb (#29)

* Added changes related to Drupal 9 compatibility (#30)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Develop into main (#25)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Develop (#28)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

* [#46397] Added menu overrides, which moves 'Webforms' and 'Maestro templates' to the main navigation

* Remove rules modules (#23)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Remove Rules modules

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Remove rules (#24)

* Remove custom_theme dependency and instead set Gin as default theme (Gin requires Claro).

* Merge Develop into Main (#21)

* Changing webform permissions for flowdesigner

* [#44232] Added yml-files for the 3 'default' date formats, to determine how they should be formatted

* [#44224] Changed permission to allow page to be added through the 'references'-tab

* [#44228] Changed permissions to allow 'selvbetjeningdesigner' to save selvbetjeningsside

* Add almost copy of Leder role as Borger role

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Remove rules branch

* No installation of Rules modules

* Update Forløb module version

Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>

* Add patch to dynamic entity reference module (#27)

* Add patch to dynamic entity reference module

* Add link to patch comment

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>

* Added changes related to Drupal 9 compatibility

* Upgrade os2forms/os2forms_forloeb to latest version

Co-authored-by: Mads Nørgaard <madsnorgaard@live.dk>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: mn <mn@magenta-aps.dk>

* Downgrade os2forms/os2forms (#31)

* Update composer.json

Upgrade to latest version of OS2forms med Forløb 1.9.0

Co-authored-by: mb <mb@magenta-aps.dk>
Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
Co-authored-by: Toke Fritzemeier <toke@magenta.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Andriyun <andriy.yun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants