Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ocsp revocation against merkle root & intermediate hashes #228

Merged
merged 6 commits into from
Jun 13, 2022

Conversation

HJunyuan
Copy link
Member

@HJunyuan HJunyuan commented Jun 6, 2022

Context

  • The original verification behaviour against an OCSP Responder started off with revocation by document ID
  • In order to align with how we perform revocation of documents issued onto the Ethereum document store, revocation by merkle root and intermediate hashes should be performed by the OCSP Responder (i.e. do not revoke by document id)
  • Related PR: feat: revocation by document hash ocsp-responder#1

What does this PR do?

  • Implement isRevokedByOcspResponder2() to check against merkle root and intermediate hashes of a document
  • Fallback to original isRevokedByOcspResponder() if OCSP Responder response is not recognised (To be removed in the future)
  • Add tests to ensure old and new OCSP Responders are handled accordingly

Copy link
Contributor

@cavacado cavacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed.

ping me again when the changes are done and I'll approve this

@HJunyuan HJunyuan requested a review from cavacado June 10, 2022 05:05
Copy link
Contributor

@cavacado cavacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@HJunyuan HJunyuan merged commit fd5d5f0 into master Jun 13, 2022
@HJunyuan HJunyuan deleted the feat/ocsp-revocation-hash branch June 13, 2022 06:07
@john-dot-oa
Copy link
Contributor

🎉 This PR is included in version 7.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

HJunyuan added a commit that referenced this pull request Feb 6, 2023
- Implement handling of `OCSP_RESPONDER` type of revocation for OA v3 documents
- Add tests for DID-issued OA v3 documents with OCSP_RESPONDER type of revocation
- Housekeeping of filenames for fixtures

BREAKING CHANGE: the old OCSP Responder implementation (where it checks by by document id instead of merkle root & intermediate hashes) is now deprecated

It is no longer possible to perform OCSP revocation by document id as mentioned in #228


Fixes #243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants