table fixes #4666
Merged
table fixes #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4666 +/- ##
==========================================
Coverage ? 56.79%
==========================================
Files ? 591
Lines ? 53880
Branches ? 0
==========================================
Hits ? 30603
Misses ? 23277
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
reviewpad
bot
added
feat S
|
should close #4646 |
IgorWounds
pushed a commit
that referenced
this pull request
Apr 6, 2023
* fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com>
IgorWounds
added a commit
that referenced
this pull request
Apr 7, 2023
* Start * QA controller tests * Unit tests batch 1 * ruff * More tests * Economy unit tests * Tests: economy * table fixes (#4666) * fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com> * bug as default flair if no login (#4681) * init (#4683) * Feature: Ultima Insights NewsMonitor Integration (#4685) * fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> * Terminal/hub QA (#4678) * move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint * Refactor sources menu (#4668) * add data sources defaults to model * fix f string * refactor sources controller * write sources to file * write to user file * add user data sources file inside OpenBBUserData * append to user file, don't rewrite * fix when sources folder does not exist * codespell * change func name * change path to str * ruff * Add method to upload entire user field * change clear func args * update get_ordered_list_sources function * move flatten * move flatten * change extend func name * remove comment * clean sources utils funcs * mypy * Update utils.py * spacing * docs --------- Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt> * Move tradier from hub to local (#4700) * Move tradier from hub to local * Flake error * Disable error * Update stocks_helper.py * Update stocks_helper.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Unit tests batch * Unit tests batch * ruff * Unit tests batch * Tests : Economy ; moving csv file * Apply black * Apply ruff --------- Co-authored-by: Chavithra PARANA <chavithra@gmail.com> Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: Adi Sai <adithya.sairam1@gmail.com> Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>
jmaslek
pushed a commit
that referenced
this pull request
Apr 13, 2023
* fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com>
jmaslek
added a commit
that referenced
this pull request
Apr 13, 2023
* Start * QA controller tests * Unit tests batch 1 * ruff * More tests * Economy unit tests * Tests: economy * table fixes (#4666) * fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com> * bug as default flair if no login (#4681) * init (#4683) * Feature: Ultima Insights NewsMonitor Integration (#4685) * fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> * Terminal/hub QA (#4678) * move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint * Refactor sources menu (#4668) * add data sources defaults to model * fix f string * refactor sources controller * write sources to file * write to user file * add user data sources file inside OpenBBUserData * append to user file, don't rewrite * fix when sources folder does not exist * codespell * change func name * change path to str * ruff * Add method to upload entire user field * change clear func args * update get_ordered_list_sources function * move flatten * move flatten * change extend func name * remove comment * clean sources utils funcs * mypy * Update utils.py * spacing * docs --------- Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt> * Move tradier from hub to local (#4700) * Move tradier from hub to local * Flake error * Disable error * Update stocks_helper.py * Update stocks_helper.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Unit tests batch * Unit tests batch * ruff * Unit tests batch * Tests : Economy ; moving csv file * Apply black * Apply ruff --------- Co-authored-by: Chavithra PARANA <chavithra@gmail.com> Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: Adi Sai <adithya.sairam1@gmail.com> Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
economy/events- output is an empty table. #4646