Terminal/hub QA #4678

montezdesousa · 2023-04-04T13:58:20Z

Description

Summary of the change / bug fix.
Link # issue, if applicable.
Screenshot of the feature or the bug before/after fix, if applicable.
Relevant motivation and context.
List any dependencies that are required for this change.

How has this been tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

Make sure affected commands still run in terminal
Ensure the SDK still works
Check any related reports

Checklist:

I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
Update our documentation following these guidelines. Update any user guides that are affected by the changes.
Update our tests following these guidelines.
Make sure you are following our CONTRIBUTING guidelines.
If a feature was added make sure to add it to the corresponding integration test script.

Others

I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.

codecov · 2023-04-05T11:16:54Z

Codecov Report

❗ No coverage uploaded for pull request base (develop@4fe6cf4). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #4678   +/-   ##
==========================================
  Coverage           ?   56.80%           
==========================================
  Files              ?      593           
  Lines              ?    54040           
  Branches           ?        0           
==========================================
  Hits               ?    30699           
  Misses             ?    23341           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint

* Start * QA controller tests * Unit tests batch 1 * ruff * More tests * Economy unit tests * Tests: economy * table fixes (#4666) * fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com> * bug as default flair if no login (#4681) * init (#4683) * Feature: Ultima Insights NewsMonitor Integration (#4685) * fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> * Terminal/hub QA (#4678) * move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint * Refactor sources menu (#4668) * add data sources defaults to model * fix f string * refactor sources controller * write sources to file * write to user file * add user data sources file inside OpenBBUserData * append to user file, don't rewrite * fix when sources folder does not exist * codespell * change func name * change path to str * ruff * Add method to upload entire user field * change clear func args * update get_ordered_list_sources function * move flatten * move flatten * change extend func name * remove comment * clean sources utils funcs * mypy * Update utils.py * spacing * docs --------- Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt> * Move tradier from hub to local (#4700) * Move tradier from hub to local * Flake error * Disable error * Update stocks_helper.py * Update stocks_helper.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Unit tests batch * Unit tests batch * ruff * Unit tests batch * Tests : Economy ; moving csv file * Apply black * Apply ruff --------- Co-authored-by: Chavithra PARANA <chavithra@gmail.com> Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: Adi Sai <adithya.sairam1@gmail.com> Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>

* move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint

* Start * QA controller tests * Unit tests batch 1 * ruff * More tests * Economy unit tests * Tests: economy * table fixes (#4666) * fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com> * bug as default flair if no login (#4681) * init (#4683) * Feature: Ultima Insights NewsMonitor Integration (#4685) * fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> * Terminal/hub QA (#4678) * move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint * Refactor sources menu (#4668) * add data sources defaults to model * fix f string * refactor sources controller * write sources to file * write to user file * add user data sources file inside OpenBBUserData * append to user file, don't rewrite * fix when sources folder does not exist * codespell * change func name * change path to str * ruff * Add method to upload entire user field * change clear func args * update get_ordered_list_sources function * move flatten * move flatten * change extend func name * remove comment * clean sources utils funcs * mypy * Update utils.py * spacing * docs --------- Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt> * Move tradier from hub to local (#4700) * Move tradier from hub to local * Flake error * Disable error * Update stocks_helper.py * Update stocks_helper.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Unit tests batch * Unit tests batch * ruff * Unit tests batch * Tests : Economy ; moving csv file * Apply black * Apply ruff --------- Co-authored-by: Chavithra PARANA <chavithra@gmail.com> Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: Adi Sai <adithya.sairam1@gmail.com> Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>

move update flair

6fccb74

montezdesousa added the account Authentication features label Apr 4, 2023

reviewpad bot added the feat XS Extra small feature label Apr 4, 2023

montezdesousa marked this pull request as ready for review April 4, 2023 14:01

montezdesousa marked this pull request as draft April 4, 2023 14:01

montezdesousa and others added 7 commits April 5, 2023 10:49

sort repr

408fa8b

remove packaged sys model var

82d1940

update decorator for check api key

91c397c

Merge branch 'develop' into hotfix/auth_qa

ef1fa8f

ruff

7117e4c

change if stat

a8c20a4

ruff

e1a8452

montezdesousa requested a review from IgorWounds April 5, 2023 10:59

montezdesousa marked this pull request as ready for review April 5, 2023 10:59

no need for new var

edef5b0

IgorWounds approved these changes Apr 5, 2023

View reviewed changes

montezdesousa enabled auto-merge April 5, 2023 11:04

pylint

427bd7b

montezdesousa disabled auto-merge April 5, 2023 11:26

montezdesousa enabled auto-merge April 5, 2023 11:26

montezdesousa added this pull request to the merge queue Apr 5, 2023

Merged via the queue into develop with commit e7b2095 Apr 5, 2023

IgorWounds pushed a commit that referenced this pull request Apr 6, 2023

Terminal/hub QA (#4678)

69ab57c

* move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint

jmaslek pushed a commit that referenced this pull request Apr 13, 2023

Terminal/hub QA (#4678)

4cbae19

* move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint

piiq deleted the hotfix/auth_qa branch April 24, 2023 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terminal/hub QA #4678

Terminal/hub QA #4678

montezdesousa commented Apr 4, 2023

codecov bot commented Apr 5, 2023 •

edited

Loading

Terminal/hub QA #4678

Terminal/hub QA #4678

Conversation

montezdesousa commented Apr 4, 2023

Description

How has this been tested?

Checklist:

Others

codecov bot commented Apr 5, 2023 • edited Loading

Codecov Report

codecov bot commented Apr 5, 2023 •

edited

Loading