Feature: Ultima Insights NewsMonitor Integration #4685

AdiSai · 2023-04-04T18:49:50Z

Description

Summary of the change / bug fix.
Integrating Ultima Insights News Monitor for the news and cnews commands
Link # issue, if applicable.
N/A
Screenshot of the feature or the bug before/after fix, if applicable.
Relevant motivation and context.
Ultima Insights' News Monitor is a platform that harnesses the power of GPT + LLMs to help deliver better, more relevant news to investors. We help find the news & tell you why it's important before it's on the front page of Bloomberg.
List any dependencies that are required for this change.
an Ultima Insights API key, available from https://www.ultimainsights.ai/

How has this been tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

Make sure affected commands still run in terminal
Ensure the SDK still works
Check any related reports

Checklist:

I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
Update our documentation following these guidelines. Update any user guides that are affected by the changes.
Update our tests following these guidelines.
Make sure you are following our CONTRIBUTING guidelines.
If a feature was added make sure to add it to the corresponding integration test script.

Others

I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.

Reopening #4644 with proper branch name conventions

…nto develop

…on't get fetched

andrewkenreich · 2023-04-04T19:35:29Z

The Merge conflicts have to be resolved here before the tests will run (we tried to fix it but we can't write to your branch)

andrewkenreich · 2023-04-04T20:54:30Z

ok should run now :)

codecov · 2023-04-05T04:54:41Z

Codecov Report

❗ No coverage uploaded for pull request base (develop@10e2b38). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #4685   +/-   ##
==========================================
  Coverage           ?   56.82%           
==========================================
  Files              ?      593           
  Lines              ?    54043           
  Branches           ?        0           
==========================================
  Hits               ?    30711           
  Misses             ?    23332           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

DidierRLopes · 2023-04-05T05:33:44Z

Let's goooo!

Great work @AdiSai ! Welcome onboard

* fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>

* Start * QA controller tests * Unit tests batch 1 * ruff * More tests * Economy unit tests * Tests: economy * table fixes (#4666) * fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com> * bug as default flair if no login (#4681) * init (#4683) * Feature: Ultima Insights NewsMonitor Integration (#4685) * fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> * Terminal/hub QA (#4678) * move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint * Refactor sources menu (#4668) * add data sources defaults to model * fix f string * refactor sources controller * write sources to file * write to user file * add user data sources file inside OpenBBUserData * append to user file, don't rewrite * fix when sources folder does not exist * codespell * change func name * change path to str * ruff * Add method to upload entire user field * change clear func args * update get_ordered_list_sources function * move flatten * move flatten * change extend func name * remove comment * clean sources utils funcs * mypy * Update utils.py * spacing * docs --------- Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt> * Move tradier from hub to local (#4700) * Move tradier from hub to local * Flake error * Disable error * Update stocks_helper.py * Update stocks_helper.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Unit tests batch * Unit tests batch * ruff * Unit tests batch * Tests : Economy ; moving csv file * Apply black * Apply ruff --------- Co-authored-by: Chavithra PARANA <chavithra@gmail.com> Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: Adi Sai <adithya.sairam1@gmail.com> Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>

* fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>

* Start * QA controller tests * Unit tests batch 1 * ruff * More tests * Economy unit tests * Tests: economy * table fixes (#4666) * fix: table fixes * fix: tablaroni * fix: pagination protection * fix: dm much more * fix: colors * fix: colors * fix: colors * fix Timestamp on stocks `get_quote` * fix `call_tob` having `quote` as prog/docstring --------- Co-authored-by: teh_coderer <me@tehcoderer.com> * bug as default flair if no login (#4681) * init (#4683) * Feature: Ultima Insights NewsMonitor Integration (#4685) * fix typing issue that prevents running * news monitor integration for news * UX improvements with news monitor integration * italicize riskExtDesc * minor cosmetic changes * minor cosmetic changes * minor cosmetic changes * Update ultima_newsmonitor_view.py * minor fixes to launch properly * setting Ultima API key * Ultima NewsMonitor integration into terminal done * integration of the commands is done * add Ultima to SDK trailmap, but SDK generation failed on M1 Mac * add tests * add unit tests * Linting and sdk * display message if not supported by Ultima News Monitor * Update api-keys.md * fix stock controller problem + remove source filtering from Ultima * remove source filtering from Ultima * add report issue message * add some error handling in the view to ensure unsupported companies don't get fetched * remove powered by Ultima Insights from console output * ran black formatter to fix linting issues * fix ruff issues * fix pylint issues * lint fix * fixed linting issue and changed keys in the Feedparser model * get all tests to pass * proper testing with --record-mode=rewrite * re-run tests for updated VCRs * redid black formatting * re-run test_print_help in stocks controller * make breaking news output consistent and re-run tests * remove unused import time * reran tests with --rewrite-expected --------- Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> * Terminal/hub QA (#4678) * move update flair * sort repr * remove packaged sys model var * update decorator for check api key * ruff * change if stat * ruff * no need for new var * pylint * Refactor sources menu (#4668) * add data sources defaults to model * fix f string * refactor sources controller * write sources to file * write to user file * add user data sources file inside OpenBBUserData * append to user file, don't rewrite * fix when sources folder does not exist * codespell * change func name * change path to str * ruff * Add method to upload entire user field * change clear func args * update get_ordered_list_sources function * move flatten * move flatten * change extend func name * remove comment * clean sources utils funcs * mypy * Update utils.py * spacing * docs --------- Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt> * Move tradier from hub to local (#4700) * Move tradier from hub to local * Flake error * Disable error * Update stocks_helper.py * Update stocks_helper.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Unit tests batch * Unit tests batch * ruff * Unit tests batch * Tests : Economy ; moving csv file * Apply black * Apply ruff --------- Co-authored-by: Chavithra PARANA <chavithra@gmail.com> Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: Adi Sai <adithya.sairam1@gmail.com> Co-authored-by: ovidysus0 <111447781+ovidysus0@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>

AdiSai and others added 27 commits February 26, 2023 16:18

fix typing issue that prevents running

489cc46

news monitor integration for news

fb85fc6

UX improvements with news monitor integration

d8043dd

italicize riskExtDesc

f86537a

minor cosmetic changes

8bb25c7

minor cosmetic changes

2e967e3

minor cosmetic changes

a46941b

Update ultima_newsmonitor_view.py

fa89951

resolving merge conflicts?

38103ad

minor fixes to launch properly

e5c5686

Merge branch 'OpenBB-finance:develop' into develop

2ac5e3e

setting Ultima API key

c43bdf6

Ultima NewsMonitor integration into terminal done

7d266cd

integration of the commands is done

cab188f

add Ultima to SDK trailmap, but SDK generation failed on M1 Mac

802240b

add tests

168e4b9

add unit tests

585f2ad

Merge branch 'OpenBB-finance:develop' into develop

0cc40e5

Linting and sdk

2491958

display message if not supported by Ultima News Monitor

d51fd17

Update api-keys.md

ca758f5

fix stock controller problem + remove source filtering from Ultima

59d63bb

Merge branch 'develop' of github.com:Ultima-Insights/OpenBBTerminal i…

9680fcb

…nto develop

remove source filtering from Ultima

894c388

add report issue message

0ee0dd8

add some error handling in the view to ensure unsupported companies d…

dd4376c

…on't get fetched

remove powered by Ultima Insights from console output

9ab1f0a

reviewpad bot added the feat M Medium T-Shirt size feature label Apr 4, 2023

AdiSai added 2 commits April 4, 2023 15:06

ran black formatter to fix linting issues

db5baf6

fix ruff issues

a504955

fix pylint issues

009864f

andrewkenreich added 2 commits April 4, 2023 16:41

Merge branch 'develop' into feature/UltimaNewsMonitor

52753d0

lint fix

1e21d9f

fixed linting issue and changed keys in the Feedparser model

9a7275f

reviewpad bot added feat XL Extra Large feature and removed feat M Medium T-Shirt size feature labels Apr 4, 2023

AdiSai added 8 commits April 4, 2023 18:57

get all tests to pass

e11864f

proper testing with --record-mode=rewrite

2ba57a1

re-run tests for updated VCRs

ba9bda8

redid black formatting

e75a538

re-run test_print_help in stocks controller

ec924e2

make breaking news output consistent and re-run tests

5b2d9f0

remove unused import time

e759865

reran tests with --rewrite-expected

5235ad9

DidierRLopes approved these changes Apr 5, 2023

View reviewed changes

DidierRLopes added this pull request to the merge queue Apr 5, 2023

Merged via the queue into OpenBB-finance:develop with commit 4fe6cf4 Apr 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Ultima Insights NewsMonitor Integration #4685

Feature: Ultima Insights NewsMonitor Integration #4685

AdiSai commented Apr 4, 2023

andrewkenreich commented Apr 4, 2023 •

edited

Loading

andrewkenreich commented Apr 4, 2023

codecov bot commented Apr 5, 2023

DidierRLopes commented Apr 5, 2023

Feature: Ultima Insights NewsMonitor Integration #4685

Feature: Ultima Insights NewsMonitor Integration #4685

Conversation

AdiSai commented Apr 4, 2023

Description

How has this been tested?

Checklist:

Others

andrewkenreich commented Apr 4, 2023 • edited Loading

andrewkenreich commented Apr 4, 2023

codecov bot commented Apr 5, 2023

Codecov Report

DidierRLopes commented Apr 5, 2023

andrewkenreich commented Apr 4, 2023 •

edited

Loading