patina_debugger: Implement single register access #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cfernald
force-pushed
the
dbg_single_reg
branch
from
931ba48 to
d1c9ca5
Compare
os-d
approved these changes
Dec 3, 2025
makubacki
approved these changes
Dec 3, 2025
5 tasks
makubacki
reviewed
Dec 4, 2025
joschock
reviewed
Dec 4, 2025
joschock
approved these changes
Dec 4, 2025
Implement the single register read and write functionality for the debugger target. Windbg uses the `P<index:value>` packets for write altered register instead of sending the full register context every time. Without this change single register edits appear to work, until the resume where the edits are lost.
vineelko
reviewed
Dec 5, 2025
cfernald
force-pushed
the
dbg_single_reg
branch
from
d1c9ca5 to
ba7d6ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the single register read and write functionality for the debugger target. Windbg uses the
P<index:value>packets for write altered register instead of sending the full register context every time.This resolves an issue where register edits appear to work, until the resume where the edits are lost.
How This Was Tested
Tested on Q35 & SBSA
Integration Instructions
N/A