Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfrom javax references left in xsd, tld and dtd #13974

Closed
44 of 60 tasks
isaacrivriv opened this issue Sep 16, 2020 · 5 comments
Closed
44 of 60 tasks

Transfrom javax references left in xsd, tld and dtd #13974

isaacrivriv opened this issue Sep 16, 2020 · 5 comments

Comments

@isaacrivriv
Copy link
Member

isaacrivriv commented Sep 16, 2020

This still needs a bit more discussion weather the change needs to happen or not

Found in com.ibm.ws.webcontainer

Compared to the servlet api files such as here, these shouldn't be updated since a new file is created for each necessary version from what I could tell like here

  • cache/java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd Shouldn't be updated
  • javax.servlet.jsp.tagext.JspTag
  • javax.servlet.jsp.tagext.TagExtraInfo
  • javax.servlet.jsp.tagext.DynamicAttributes
  • javax.serlvet.jsp.tagext.JspTag
  • javax.servlet.jsp.tagext.TagExtraInfo
  • javax.jsp.tagext.JspFragment
  • cache/java.sun.com/xml/ns/j2ee/j2ee_web_services_client_1_1.xsd
  • javax.xml.rpc.Service Looking at here and here looks like xml rpc was removed from EE9 so should not update
  • cache/java.sun.com/xml/ns/j2ee/j2ee_jaxrpc_mapping_1_1.xsd
  • javax.xml.rpc.Service Looking at here and here looks like xml rpc was removed from EE9 so should not update
  • cache/java.sun.com/xml/ns/j2ee/j2ee_1_4.xsd
  • javax.jms.Queue
  • cache/java.sun.com/xml/ns/j2ee/ejb-jar_2_1.xsd
  • javax.jms.MessageListener
  • cache/java.sun.com/xml/ns/j2ee/connector_1_5.xsd
  • javax.resource.spi.ActivationSpec
  • javax.jms.Destination
  • javax.jms.MessageListener
  • javax.resource.spi.security.PasswordCredential
  • javax.resource.spi.security.GenericCredential
  • javax.resource.spi.ManagedConnectionFactory
  • javax.resource.cci.ConnectionFactory
  • javax.resource.cci.Connection
  • javax.resource.spi.ResourceAdapter
  • cache/java.sun.com/j2ee/dtds/web-jsptaglibrary_1_1.dtd
  • javax.servlet.jsp.tagext.Tag
  • javax.servlet.jsp.tagext.TagExtraInfo
  • cache/java.sun.com/dtd/web-jsptaglibrary_1_2.dtd
  • javax.servlet.jsp.tagext.Tag
  • javax.servlet.jsp.tagext.TagExtraInfo
  • cache/java.sun.com/dtd/web-app_2_3.dtd
  • javax.jms.Queue
  • cache/java.sun.com/dtd/ejb-jar_2_0.dtd
  • javax.jms.Queue
  • javax.jms.Topic
  • cache/java.sun.com/dtd/connector_1_0.dtd
  • javax.resource.spi.security.PasswordCredential
  • javax.resource.spi.security.GenericCredential
  • javax.resource.cci.Connection
  • javax.resource.cci.ConnectionFactory
  • javax.resource.spi.ManagedConnectionFactory
  • cache/java.sun.com/dtd/application-client_1_3.dtd
  • javax.jms.Queue

Found in com.ibm.websphere.javaee.jsp.tld.2.2 project

The project uses a pretty old jar which is not maintained anymore. Looking to be updated in here so probably the transformation isn't even necessary. Holding out until delivery of the PR to reconsider if the changes need to happen

  • META-INF/x.tld
  • javax.servlet.jsp.jstl.core.LoopTagStatus
  • META-INF/sql.tld
  • javax.servlet.jsp.jstl.sql
  • META-INF/fmt.tld
  • javax.servlet.jsp.jstl.fmt.LocalizationContext
  • META-INF/c.tld
  • javax.servlet.jsp.jstl.core.LoopTagStatus
  • javax.servlet.jsp.jstl.core.LoopTag
  • META-INF/c-1_1.tld
  • javax.servlet.jsp.jstl.core.LoopTagStatus
  • javax.servlet.jsp.jstl.core.LoopTag
  • org/apache/taglibs/standard/resources/Resources.properties
  • javax.servlet.jsp.jstl.sql.maxRows
  • org/apache/taglibs/standard/resources/Resources_ja.properties
  • javax.servlet.jsp.jstl.sql.maxRows
@isaacrivriv isaacrivriv self-assigned this Sep 16, 2020
@isaacrivriv
Copy link
Member Author

Split issue from #13950

@isaacrivriv
Copy link
Member Author

isaacrivriv commented Dec 4, 2020

After looking a bit more and comparing with the servlet open source project for jakarta this one doesn't update the previous fragments or xmls for previous versions, however, the jstl project does. Im not sure if the files in webcontainer should be left as is but the files in jsp.jstl 2.2 should be updated with jakarta. We could either make the changes in both projects to update all references, or make the change in the jstl project and not the webcontainer one following the open source.

@isaacrivriv
Copy link
Member Author

Leaving paused until this gets delivered to verify if the updates need to happen

@isaacrivriv
Copy link
Member Author

This issue is pending the Jakarta work for tools needed to verify the rename work done is what was needed

@isaacrivriv
Copy link
Member Author

Capturing remaining work on #18470 and closing issue up since the remaining work has been finished. Moving the PR to point to new issue

@pnicolucci pnicolucci moved this to Completed Tasks in Web Tier Team May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment