Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bundle com.ibm.websphere.javaee.jsp.tld.2.2 #18470

Open
isaacrivriv opened this issue Sep 7, 2021 · 3 comments
Open

Rename bundle com.ibm.websphere.javaee.jsp.tld.2.2 #18470

isaacrivriv opened this issue Sep 7, 2021 · 3 comments

Comments

@isaacrivriv
Copy link
Member

isaacrivriv commented Sep 7, 2021

Following up on issue #13974 the remaining work is the rename work needed on the bundle com.ibm.websphere.javaee.jsp.tld.2.2. The work is already done by #15913 but there is currently no way to test the changes. The bundle is only used to tools and currently there is no ongoing work involving Jakarta in tools. Once the work is started, this issue would need to be revisited and verified so that the rename changes work as expected and can be tested. An equivalent issue has been opened in the tools repository OpenLiberty/open-liberty-tools#431 so that the tools team can take a look

@volosied
Copy link
Member

volosied commented Nov 4, 2021

Jared is working to rename the com.ibm.websphere.javaee.jsp.tld.2.2 jar -- #19216

However, it still uses transformation and the apache impl.

When we follow up, we should do the work in the new bundle: io.openliberty.jakarta.pages.tld.3.0

@isaacrivriv
Copy link
Member Author

With #19216 merged, it involves the changes proposed in #15913 so closing this PR. Since there has been no testing of the changes still due to it only being used in tools, this issue will remain open for any follow up changes such as verifying if the oracle packages com/oracle/wls/shaded/* need to be included.

@jhanders34
Copy link
Member

However, it still uses transformation and the apache impl.

Just for clarification, after talking with Volodymyr, I switched to not use transformation and to just pull in the updated code that doesn't require transformation. This makes sure that the code that is in the runtime and in the API jar are the same code and not different from each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Jakarta 9 - Open Work
Development

Successfully merging a pull request may close this issue.

4 participants