Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSTL JSP bundle transformation #15913

Closed
wants to merge 1 commit into from
Closed

JSTL JSP bundle transformation #15913

wants to merge 1 commit into from

Conversation

isaacrivriv
Copy link
Member

@isaacrivriv isaacrivriv commented Feb 12, 2021 •
edited
Loading

fixes #18470

  • Added new bundle for WDT exports based on glassfish jstl
  • Removed legacy bundle transform
  • Updated pages feature to use the new bundle

@isaacrivriv isaacrivriv self-assigned this Feb 12, 2021
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 3 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 6 infrastructure code files were changed.

@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_bhFAwG-qEeu93_rH8DpK2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

The build isaacrivriv-15913-20210215-0931
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_bhFAwG-qEeu93_rH8DpK2g
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_bhFAwG-qEeu93_rH8DpK2g

@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_dBlgsHJcEeu93_rH8DpK2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

The build isaacrivriv-15913-20210218-1951
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_dBlgsHJcEeu93_rH8DpK2g
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_dBlgsHJcEeu93_rH8DpK2g

@isaacrivriv
Initial commit
22735f9 
- Added new bundle for WDT exports based on glassfish jstl
- Removed legacy bundle transform
- Updated pages feature to use the new bundle
@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_9kHDMOMXEeuCcLcxc13g-w

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

The build isaacrivriv-15913-20210712-0756
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_9kHDMOMXEeuCcLcxc13g-w
completed successfully!

volosied
volosied reviewed Jul 14, 2021
View reviewed changes
...o.openliberty.jakarta.tags.pages.3.0.internal/.settings/.settings/org.eclipse.jdt.core.prefs
@@ -0,0 +1,276 @@
#Ant properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File seems awfully long. It may have been messed up by an IDE? Can you double check it?

volosied
volosied reviewed Jul 14, 2021
View reviewed changes
dev/io.openliberty.jakarta.tags.pages.3.0.internal/.settings/.settings/org.eclipse.jdt.ui.prefs
@@ -0,0 +1,62 @@
#Ant properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the the other comment.

@isaacrivriv isaacrivriv mentioned this pull request Jul 20, 2021
Open
@isaacrivriv isaacrivriv mentioned this pull request Sep 7, 2021
Open
@isaacrivriv
Copy link
Member Author

Closing PR due to changes already included in #19216

@isaacrivriv isaacrivriv closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volosied volosied volosied left review comments

@pnicolucci pnicolucci Awaiting requested review from pnicolucci

Assignees

@isaacrivriv isaacrivriv

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename bundle com.ibm.websphere.javaee.jsp.tld.2.2
3 participants
@isaacrivriv @LibbyBot @volosied