Transformed third party and stable API bundle updates and other updates #19216

jhanders34 · 2021-11-02T18:17:47Z

Update ejbcontainer javadoc to include com.ibm.websphere.ejbcontainer package
Update transformed package versions and bundle name for grpc third party and stable bundles
Update transformed bundle name for pages tld bundle
Update transformed bundle name for org.osgi.service.http bundle and do not include it in the dev/api directory any longer
Update to only include the transformed javadoc zip for the transformed projects.

jhanders34 · 2021-11-02T18:20:22Z

#build

LibbyBot · 2021-11-02T18:20:31Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2021-11-02T18:20:34Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_MDYfkDwBEeygsrM6ShizkA

Target locations of links might be accessible only to IBM employees.

tkburroughs

EJB changes look good.

neuwerk

Web Service related changes look good to me! Thanks Jared!

jhanders34 · 2021-11-02T21:00:26Z

#libby #build

LibbyBot · 2021-11-02T21:00:35Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2021-11-02T21:00:36Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_i4DvQDwXEeygsrM6ShizkA

Target locations of links might be accessible only to IBM employees.

jhanders34 · 2021-11-03T13:18:48Z

#libby #build

LibbyBot · 2021-11-03T13:18:57Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2021-11-03T13:19:00Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_OXuggDygEeygsrM6ShizkA

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2021-11-04T05:34:24Z

The build jhanders34-19216-20211103-0626
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_OXuggDygEeygsrM6ShizkA
completed successfully!

- Add to the buildpath so that the source is found to generate the javadoc for com.ibm.websphere.ejbcontainer package.

…pec directory.

volosied · 2021-11-04T14:06:00Z

dev/io.openliberty.jakarta.pages.tld.3.0/bnd.bnd

+    org.apache.taglibs.standard.tag.common.core;version="1.0.0", \
+    org.apache.taglibs.standard.tag.common.xml;version="1.0.0", \
+    org.apache.taglibs.standard.tag.el.core;version="1.0.0", \
+    org.apache.taglibs.standard.tag.el.fmt;version="1.0.0", \
+    org.apache.taglibs.standard.tag.el.sql;version="1.0.0", \
+    org.apache.taglibs.standard.tag.el.xml;version="1.0.0", \
+    org.apache.taglibs.standard.tag.rt.core;version="1.0.0", \
+    org.apache.taglibs.standard.tag.rt.fmt;version="1.0.0", \
+    org.apache.taglibs.standard.tag.rt.sql;version="1.0.0", \
+    org.apache.taglibs.standard.tag.rt.xml;version="1.0.0"


Spoke with my team -- Should this be 1.0.0 because it's a new bundle? Or should it be 2.0 since these are the EE9 versions of the classes (albeit transformed)

Ah, the previous bundle used 1.0.0 -- let's use 2.0 here instead.

Why is the bundle version 1.2?

dev/io.openliberty.jakarta.pages.tld.3.0/bnd.bnd

tevans78 · 2021-11-04T16:02:03Z

dev/io.openliberty.grpc.client.1.0.jakarta.thirdparty/bnd.bnd

+-buildpath: \
+  com.google.errorprone:error_prone_annotations;version=2.4.0,\
+  io.grpc:grpc-netty;version=${grpcVersion},\
+  io.netty:netty-buffer;version=${nettyVersion},\


Wouldn't it be better to depend on the existing netty bundle io.openliberty.io.netty?

tevans78 · 2021-11-04T16:06:13Z

dev/io.openliberty.grpc.client.1.0.jakarta.thirdparty/bnd.bnd

+
+Export-Package:\
+  io.grpc.netty;version=${grpcVersion}, \
+  io.netty.handler.ssl;version=${nettyVersion}


package is already exported by io.openliberty.io.netty.ssl so why not use that?

Spoke to Bill Lucy, these bundles are third-party and io.openliberty.io.netty.ssl is an internal bundle. Customer would not be able to use this package otherwise.

tevans78 · 2021-11-04T16:19:27Z

dev/io.openliberty.io.grpc.1.0.jakarta/bnd.bnd

+bVersion=1.0
+grpcVersion=1.38.1
+
+Bundle-SymbolicName: io.openliberty.io.grpc.1.0.javaee; singleton:=true


Why include 1.0 in the name of the bundle?

this is a stable API bundle - based on https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-naming-guidelines we thought the 1.0 made sense

tevans78

While I did leave some comments, strictly they do not come from the changes that Jared is making... so approving this PR

volosied

looks good, thanks 👍

jhanders34 · 2021-11-04T17:34:01Z

#libby

LibbyBot · 2021-11-04T17:34:11Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

32 product code files were changed.
Please describe in a separate comment how you tested your changes.
21 infrastructure code files were changed.

jhanders34 added team:Performance jakartaEE9 labels Nov 2, 2021

jhanders34 added this to the [Iteration 21.22] Oct 25 - Nov 5 milestone Nov 2, 2021

jhanders34 requested review from volosied, neuwerk, tevans78 and tkburroughs November 2, 2021 18:17

jhanders34 self-assigned this Nov 2, 2021

LibbyBot added the CLA Signed label Nov 2, 2021

volosied requested a review from wtlucy November 2, 2021 18:30

tkburroughs approved these changes Nov 2, 2021

View reviewed changes

neuwerk approved these changes Nov 2, 2021

View reviewed changes

jhanders34 force-pushed the more_eclipse_cleanup branch from e97440c to 418bd05 Compare November 2, 2021 21:00

jhanders34 force-pushed the more_eclipse_cleanup branch from 418bd05 to a1c7768 Compare November 2, 2021 21:01

jhanders34 added 4 commits November 4, 2021 05:53

Update ejbcontainer API projects to make correct Javadoc

155663c

- Add to the buildpath so that the source is found to generate the javadoc for com.ibm.websphere.ejbcontainer package.

Update to only publish on javadoc zip file.

540906a

Update grpc APIs to have the right pom file in the bundle.

0ff35ca

Update org.osgi.service.http jakarta bundle and don't put it in the s…

70c37b0

…pec directory.

jhanders34 force-pushed the more_eclipse_cleanup branch from bc5d1e9 to be3b514 Compare November 4, 2021 11:08

volosied mentioned this pull request Nov 4, 2021

Rename bundle com.ibm.websphere.javaee.jsp.tld.2.2 #18470

Open

volosied reviewed Nov 4, 2021

View reviewed changes

tevans78 reviewed Nov 4, 2021

View reviewed changes

tevans78 approved these changes Nov 4, 2021

View reviewed changes

jhanders34 added 3 commits November 4, 2021 11:58

Update jsp tld transformed bundle name.

b5159e3

Transformed package version updates.

8e36560

Update to handle new javaee to jakarta conversion.

005b802

jhanders34 force-pushed the more_eclipse_cleanup branch from be3b514 to 005b802 Compare November 4, 2021 16:58

volosied approved these changes Nov 4, 2021

View reviewed changes

jhanders34 merged commit 108964d into OpenLiberty:integration Nov 4, 2021

isaacrivriv mentioned this pull request Nov 4, 2021

JSTL JSP bundle transformation #15913

Closed

mhldr mentioned this pull request Nov 5, 2021

Revert "Transformed third party and stable API bundle updates and other updates" #19257

Merged

LibbyBot mentioned this pull request Nov 5, 2021

Re-introduce change reverted from 19216 #19258

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transformed third party and stable API bundle updates and other updates #19216

Transformed third party and stable API bundle updates and other updates #19216

jhanders34 commented Nov 2, 2021

jhanders34 commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

tkburroughs left a comment

neuwerk left a comment

jhanders34 commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

jhanders34 commented Nov 3, 2021

LibbyBot commented Nov 3, 2021

LibbyBot commented Nov 3, 2021

LibbyBot commented Nov 4, 2021

volosied Nov 4, 2021

volosied Nov 4, 2021 •

edited

Loading

tevans78 Nov 4, 2021

tevans78 Nov 4, 2021

tevans78 Nov 4, 2021

volosied Nov 4, 2021

tevans78 Nov 4, 2021

wtlucy Nov 4, 2021

tevans78 left a comment

volosied left a comment

jhanders34 commented Nov 4, 2021

LibbyBot commented Nov 4, 2021

Transformed third party and stable API bundle updates and other updates #19216

Transformed third party and stable API bundle updates and other updates #19216

Conversation

jhanders34 commented Nov 2, 2021

jhanders34 commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

tkburroughs left a comment

Choose a reason for hiding this comment

neuwerk left a comment

Choose a reason for hiding this comment

jhanders34 commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

LibbyBot commented Nov 2, 2021

jhanders34 commented Nov 3, 2021

LibbyBot commented Nov 3, 2021

LibbyBot commented Nov 3, 2021

LibbyBot commented Nov 4, 2021

volosied Nov 4, 2021

Choose a reason for hiding this comment

volosied Nov 4, 2021 • edited Loading

Choose a reason for hiding this comment

tevans78 Nov 4, 2021

Choose a reason for hiding this comment

tevans78 Nov 4, 2021

Choose a reason for hiding this comment

tevans78 Nov 4, 2021

Choose a reason for hiding this comment

volosied Nov 4, 2021

Choose a reason for hiding this comment

tevans78 Nov 4, 2021

Choose a reason for hiding this comment

wtlucy Nov 4, 2021

Choose a reason for hiding this comment

tevans78 left a comment

Choose a reason for hiding this comment

volosied left a comment

Choose a reason for hiding this comment

jhanders34 commented Nov 4, 2021

LibbyBot commented Nov 4, 2021

Code analysis and actions

volosied Nov 4, 2021 •

edited

Loading