Fixes for #1564 and #1289

[addison74]

This PR fixes #1564 and #1289 . Please read bellow my comments for every commit.

[kiatng]

The 2 issues are not related and should be split into 2 separate PRs. It will be easier to review.

[addison74]

@kiatng: I used the GitHub interface when I posted them and I'm not very familiar with it. I'm sorry for this inconvenience.

The only commit that needs attention is the one related to the order of the attributes in the comparison window. The code does not belong to me, but it works, I have been testing it for over 5 years. It may require optimization or another approach. In any case, this issue had to be solved for a long time.

[addison74]

I did not find in the latest OpenMage the changes related to this #1289, even this PR was approved and fix it.

Maybe I am wrong ... but in the comparison window attributes are not following their set up position.

[addison74]

In this file

/app/code/core/Mage/Catalog/Model/Resource/Product/Compare/Item/Collection.php

line 209 function getComparableAttributes() was change again after this PR to the initial behavior. This is the reason the attributes in comparison window are not following the order set up the Backend.

[addison74]

This PR is responsible #2993. The function mentioned above has been radically modified, but the check whether the attributes are in order or not has not been done. fortunately, thanks to the migration of a store where I had custom changes, I was able to identify this problem. my opinion that that PR needs to be reviewed carefully.

@davidhiendl - may I ask why you changed the function getComparableAttributes() although it solved the problem related to the order of the attributes in the comparison window?

[davidhiendl]

@addison74 The aim of the PR was to reduce the countless DB queries made for fetching attributes for a single batch call to cache storage or database. getComparableAttributes however does not have any impact on the layered navigation plus I cannot reproduce the problem. Also the new function implements the same database logic from cached data:

• fetch attributes for setIds
• filter by is_comparable
• sort order by position

Edit: Actually there might be, DB did sort by two dimensions: attribute_group_id and sort_order but I still don't think it would have any impact.

Edit2: Also I was unaware that it got merged back into the old 1.9.x branch, I was under the impression it was only on 20.x

[addison74]

My PR was related to the wrong positioning of the attributes in the comparison window. Your PR came after and modified my changes and now I am not able to see the attributes in the order I set up.

Please note it is not related to layering navigation, that one is a separate issue.