update install instructions to reflect the further documentation link #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a bit of confusion. the branches for them are still We do have additionally our own Major Versions with own branches http://www.openmage.org/supported-versions.html |
kkrieger85
approved these changes
Jun 4, 2020
|
Maybe we should add a branch alias so people can install using |
Flyingmana
suggested changes
Jun 4, 2020
| @@ -7,18 +7,18 @@ level of backwards compatibility to the official releases. | |||
| **Pull requests with unofficial bug fixes and security patches from the community are encouraged and welcome!** | |||
|
|
|||
| Though Magento does not follow [Semantic Versioning](http://semver.org/) we aim to provide a workable system for | |||
| dependency definition. Each Magento `1.<minor>.<revision>` release will get its own branch (named `1.<minor>.<revision>.x`) | |||
| dependency definition. Each Magento `1.<minor>.<revision>` release will get its own branch (named `1<minor>.<revision>.x`) | |||
There was a problem hiding this comment.
This line needs to be changed to ..x
sreichel
requested changes
Aug 22, 2020
| that will be independently maintained with upstream patches and community bug fixes for as long as it makes sense | ||
| to do so (based on available resources). For example, Magento version `1.9.3.4` was merged into the `1.9.3.x` branch. | ||
| to do so (based on available resources). For example, Magento version `1.9.3.4` was merged into the `19.3.x` branch. |
There was a problem hiding this comment.
No. There was no 19.3.x branch ... it was 1.9.3.x.
|
|
||
| ## Installation | ||
|
|
||
| Download the latest archive and extract it, clone the repo, or add a composer dependency to your existing project like so: | ||
|
|
||
| ```json | ||
| "openmage/magento-lts": "1.9.4.x" | ||
| "openmage/magento-lts": "19.4.x" |
There was a problem hiding this comment.
Should be a release number or branch ... it's neither nor (also before)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current composer install instruction below doesn't work:
"openmage/magento-lts": "1.9.4.x"so have updated to reflect the instructions in http://www.openmage.org/magento-lts/install.html that do