Merged
Conversation
… the documentation
…m Icons when available
Usage of MSL 4.0.0 after applying the conversion script
The Modelica grammar does not allow annotations except at the end of a class.
* Convert to MSL 4.0.0 * Update version number to 1.0.3
MSL 4.0.0
# Conflicts: # BioChem/Interfaces/Reactions/Basics/FourSubstrates.mo # BioChem/Units/package.mo
UsersGuide package (OpenModelica#21)
Physical units (OpenModelica#23)
Issue25 fix error (OpenModelica#26)
…ments so that the icon remain in green as in previous release
…s.Interfaces.Compartments
sjoelund
reviewed
Apr 29, 2021
Member
sjoelund
left a comment
sjoelund
left a comment
There was a problem hiding this comment.
It seems like the icons are models or packages or connectors. This means that the icons can only be inherited by classes of the same kind.
If they were of type class, anything could use the icon.
Collaborator
Author
|
Good point .. At some time point I suffered from inheritance. Packages will remain packages because they correspond to packages and should be inherited only by packages. For the rest, they can become classes. |
sjoelund
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All / most graphical annotations have been moved to the package BioChem.Icons.* in a one-one manner