Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "other" dimension more flexible #138

Open
ckolbPTB opened this issue Dec 21, 2023 · 2 comments
Open

Make "other" dimension more flexible #138

ckolbPTB opened this issue Dec 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@ckolbPTB
Copy link
Collaborator

Suggestion by @fzimmermann89

Re the other dimension:

I would prefer if we allow in our code for this dimension to actually be more than 1 dimensnion.
So we dont split the KData into dynamics, ... by default, but our code works if it is split.

This would, as a start, mean replacing 'other' by '...' in all einops pattern, and counting dimensions from the back for swapaxes etc.

@ckolbPTB ckolbPTB added enhancement New feature or request help wanted Extra attention is needed labels Dec 21, 2023
@ckolbPTB ckolbPTB mentioned this issue Dec 21, 2023
@ckolbPTB ckolbPTB added this to the Hackathon 6 milestone Jun 25, 2024
@ckolbPTB
Copy link
Collaborator Author

ckolbPTB commented Jun 27, 2024

Make sure that always the correct terms (e.g. coils and not coil) are used.

Functions/Classes to double check

This probably wont work for flexible other dimensions but will be replaced at some point anyway:

@ckolbPTB
Copy link
Collaborator Author

ckolbPTB commented Jul 2, 2024

Start by modifying the tests such that they fail for a current inflexible use of other (e.g. simply add an additional other singleton dimension) and then fix it.

@guastinimara guastinimara self-assigned this Jul 9, 2024
@ckolbPTB ckolbPTB linked a pull request Jul 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants