-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "other" dimension more flexible #138
Comments
Make sure that always the correct terms (e.g. coils and not coil) are used. Functions/Classes to double check
This probably wont work for flexible other dimensions but will be replaced at some point anyway:
|
Start by modifying the tests such that they fail for a current inflexible use of other (e.g. simply add an additional other singleton dimension) and then fix it. |
Suggestion by @fzimmermann89
Re the other dimension:
I would prefer if we allow in our code for this dimension to actually be more than 1 dimensnion.
So we dont split the KData into dynamics, ... by default, but our code works if it is split.
This would, as a start, mean replacing 'other' by '...' in all einops pattern, and counting dimensions from the back for swapaxes etc.
The text was updated successfully, but these errors were encountered: