Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than one other dim in KTrajectory #160

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

fzimmermann89
Copy link
Member

Just relaxes one of the checks: KTrajectory can now be created from tensors with more than 4 dimensions

Copy link
Contributor

github-actions bot commented Feb 11, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms
   _remove_readout_os.py30293%46, 48
src/mrpro/data
   _AccelerationFactor.py13130%15–36
   _AcqInfo.py64198%93
   _Data.py15287%58, 73
   _DcfData.py78396%71, 97, 178
   _IData.py57788%44, 49, 109, 114, 122, 128, 132
   _IHeader.py58297%86, 113
   _KData.py1081289%83–84, 166, 168, 198, 203–204, 248, 250, 254, 284, 300
   _KHeader.py125993%34, 81, 119, 170, 181, 188–189, 192, 199
   _KNoise.py21957%48–61
   _KTrajectory.py39295%142, 162
   _SpatialDimension.py39587%74, 77, 84–86
   _TrajectoryDescription.py14193%35
src/mrpro/data/traj_calculators
   _KTrajectoryCalculator.py26388%37, 63, 65
   _KTrajectoryIsmrmrd.py15287%55, 62
   _KTrajectoryPulseq.py33197%72
src/mrpro/operators
   _FourierOp.py112695%43–50, 205, 255
   _LinearOperator.py20290%46, 51
   _ZeroPadOp.py15193%45
src/mrpro/utils
   _rgetattr.py3167%20
   _zero_pad_or_crop.py30680%37, 41, 64, 67, 70, 73
TOTAL14929094% 

Tests Skipped Failures Errors Time
110 0 💤 0 ❌ 0 🔥 36.439s ⏱️

@schuenke
Copy link
Collaborator

Maybe we should include the refactoring of the rest of the code (as mentioned in #138) in this PR? It's adjusted in many functions already, but I think we didn't adjust all code yet.

@fzimmermann89
Copy link
Member Author

I am pretty sure there are lots of functions left that could use a fix - - but this particular one I need right know and would like to get merged ASAP..

@schuenke schuenke self-requested a review February 12, 2024 08:55
@fzimmermann89 fzimmermann89 merged commit 4fa2fe7 into main Feb 12, 2024
4 checks passed
@fzimmermann89 fzimmermann89 deleted the fix_other_ktraj branch February 12, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants