-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more than one 'other' dimension #359
Open
guastinimara
wants to merge
5
commits into
main
Choose a base branch
from
issue_138
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+51
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzimmermann89
force-pushed
the
issue_138
branch
from
September 28, 2024 14:26
139b0cd
to
0cc52e0
Compare
I addresse some of my previous remarks in the merge commit and found a couple of other instances |
fzimmermann89
force-pushed
the
issue_138
branch
from
September 28, 2024 14:31
0cc52e0
to
a7b45d8
Compare
fzimmermann89
force-pushed
the
issue_138
branch
from
September 28, 2024 16:07
a7b45d8
to
d476a24
Compare
📚 Documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some initial changes to deal with some of the other dimension for issue #138.
Still working on this at the moment, just wanted to be sure that I understood it and that this is the way that we would like to have it