Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] pir dy2st unittest verification - Part 5 #58965

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Nov 13, 2023

PR types

Others

PR changes

Others

Description

状态 单测 备注
🚧 test_cast TestNotVarCast 已知问题 UnboundLocalError: cannot access local variable 'grad_info_map' where it is not associated with a value
🚧 test_cinn_prim {TestPrimForwardAndBackward, TestPrimForward}.check_prim 单测需要修改
test_ast_util transformed
🚧 test_tensor_hook OpResult.register_hook需要适配, 连锁适配paddle.static.py_func
test_container TestSequential 需要适配OpResult.__eq__
test_variable_trans_func transformed

相关链接:

Copy link

paddle-bot bot commented Nov 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 13, 2023
@gouzil gouzil requested review from SigureMo and removed request for SigureMo November 13, 2023 15:56
@gouzil gouzil requested a review from SigureMo November 14, 2023 04:35
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow


@test_ast_only
@test_legacy_and_pir
def test_cast_result(self):
self.set_func()
# breakpoint()
# print("run once!!!")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#58959 预计今天就能合已经合了,下一个 PR 可以尝试开启这个单测,看看能不能过

另外这两行注释下个 PR 也可以删掉

@@ -171,7 +171,7 @@ def test_cinn_prim(self):


class TestBackend(Dy2StTestBase):
@test_legacy_and_pir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最终态尚未打通 CINN,这里能跑过应该是 CINN 没有生效,这个标记一下「编译器」未支持吧

这个单测可以先开着

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants