Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] pir dy2st unittest verification - Part 15 #59569

Merged
merged 18 commits into from
Dec 12, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Nov 30, 2023

PR types

Others

PR changes

Others

Description

状态 单测 错误类别 备注 报错信息
test_origin_info 功能测试,无需覆盖 好像没有测运行,或许可以不用测那么多
test_cpu_cuda_to_tensor
test_lstm: test_lstm_to_static API RNN 相关 API 没有适配 TypeError: Cannot interpret '<DataType.FLOAT32: 10>' as a data type
test_lstm: test_lstm_to_static 精度问题 PIR + SOT 会导致精度不足 Not equal to tolerance rtol=1e-05, atol=0
test_lstm: test_lstm_to_static 动转静执行 EagerTensor 传入到 API 中,需要将其转换为 Value,将会在 #59761 完成
🟡 test_lstm: test_lstm_to_static API paddle.jit.api.save需要适配
test_break_continue: {test_continue_in_while, test_break_in_while} 其他 base.dygraph.to_variable改为paddle.to_tensor会导致精度不足
🟡 test_break_continue: TestOptimBreakInFor 控制流 这个报错还挺奇怪的记录一下 RuntimeError: Unable to cast Python instance to C++ type (#define PYBIND11_DETAILED_ERROR_MESSAGES or compile in debug mode for details)
test_transformer

相关链接:

@paddle-bot paddle-bot bot added the contributor External developers label Nov 30, 2023
@gouzil gouzil requested a review from SigureMo November 30, 2023 23:40
@SigureMo
Copy link
Member

3 个 PT cases 在修复 enable_to_static 问题后暴露问题在 ValueExecutionInfo::Addvar_list_.size() != var_name_2_id_.size(),初步定位是前一个 ValueExecutionInfo::Renamenew_name 已经存在在 var_name_2_id_ 导致的问题,根据 LOG 可以发现这个 new_name 对应的 Var 前面已经 erase 了,也许维护这几个 map 出了问题?没有继续深入了

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit dbbe99c into PaddlePaddle:develop Dec 12, 2023
@gouzil gouzil deleted the dy2st_pir_api_push_15 branch December 27, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants