[Dy2St] pir dy2st unittest verification - Part 9 #59232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigureMo
previously approved these changes
Nov 23, 2023
| @@ -39,8 +39,10 @@ | |||
|
|
|||
|
|
|||
| def convert_attr(x, attr): | |||
There was a problem hiding this comment.
elif 好像没必要存在？直接删掉即可
这里应该是为了对齐动态图 x.size 和老 IR x.size() 动静不统一的问题的，在 PIR 下动静统一，所以 convert_attr 以及 AttributeJstTransformer 应该都是可以清理了的
我觉得我们可以记一个 TODO(cleanup-legacy-ir)，说明下老 IR 退场时是可以直接删掉相关 convert 和 Transformer
SigureMo
reviewed
Nov 23, 2023
| @@ -356,6 +372,43 @@ def clone(self): | |||
| """ | |||
| return paddle.assign(self) | |||
|
|
|||
| @fake_interface_only | |||
| def clear_gradient(self): | |||
There was a problem hiding this comment.
TODO: 等 CI 过了让震哥来 review API 变动
This was referenced Nov 23, 2023
|
需要解决下冲突 |
…_push_9 # Conflicts: # python/paddle/pir/math_op_patch.py
done |
…_push_9 # Conflicts: # test/dygraph_to_static/test_mnist.py # test/dygraph_to_static/test_tensor_methods.py # test/dygraph_to_static/test_tensor_shape.py # test/dygraph_to_static/test_train_step.py
0x45f
reviewed
Nov 28, 2023
| @@ -31,6 +32,21 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def _fake_interface_only_(func): | |||
There was a problem hiding this comment.
framework.py中有一个相同的_fake_interface_only_函数，能直接用framework.py中的那个函数吗？
Aurelius84
approved these changes
Nov 29, 2023
| to_static, | ||
| prediction, | ||
| [img.name], | ||
| img = to_variable(dy_x_data) |
There was a problem hiding this comment.
后续遇到类似to_variable这种旧的API，可否替换为paddle.to_tensor?
sunzhongkai588
approved these changes
Nov 29, 2023
|
tianshuo78520a
approved these changes
Nov 29, 2023
This was referenced Nov 29, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
test_train_stepAttributeError: 'paddle.base.libpaddle.pir.OpResult' object has no attribute 'backward'test_train_step_resnet18_sgdtest_train_step_resnet18_adamtest_tensor_shape:{TestOpNumWithTensorShapeInIf1, TestOpNumWithTensorShapeInFor1, TestOpNumWithTensorShapeInWhile1}test_mnist:test_mnist_to_staticpartial_program_layer_prepare_attributes时候报错，self.program 里调用_append_backward_desc会报错test_tensor_methodssize的改动可以看一下#58987test_tensor_memcpy_on_gputest_for_enumerate.py:TestForIterVarNumpytest_for_enumerate.py:TestForEnumerateVarWithNestedRangeTestForIterVarNumpy的TestForEnumerateVarWithNestedRange包含控制流，所以不支持；另外注意这个 case 中间态也有问题，中间态会在 Win 和 mac CI 上挂掉，本地没问题相关链接: