Suppress warning of implicitly install package.xml file #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ('share/ament_index/resource_index/packages', | ||
| ['resource/' + package_name]), | ||
| ('share/' + package_name, ['package.xml']), | ||
| ('share/' + package_name + '/scripts', glob('scripts/display_urdf')), |
There was a problem hiding this comment.
Does this really install all scripts correctly? I would have thought we should rather fix the original CMakeLists.txt, but I'm fine if this works for now
There was a problem hiding this comment.
Ok, I see that per migration guide pure python packages should just run the setup.py
henningkayser
approved these changes
Nov 13, 2019
Yes, we're taking over the migration efforts of all direct package dependencies. For the new PR we should revert the changes in terms of license and maintainer. I'll merge this now, anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to suppress the warnings that the package.xml is not explicitly installed.
Warning message:
@henningkayser I think the original PR to
ros/urdf_parser_pywill not be updated further from AcutronicRobotics. Are we planning to file a new PR?