Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the BinaryReader/Writer in all protocols #1156

Open
IntegratedQuantum opened this issue Mar 5, 2025 · 2 comments
Open

Use the BinaryReader/Writer in all protocols #1156

IntegratedQuantum opened this issue Mar 5, 2025 · 2 comments
Labels
contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers refactor shuffle a lot of code around
Milestone
Short-Term Goals

Comments

@IntegratedQuantum
Copy link
Member

This would improve their error handling and simplify the code.

For an example you can check f3b508b
@IntegratedQuantum IntegratedQuantum added contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers refactor shuffle a lot of code around labels Mar 5, 2025
@IntegratedQuantum IntegratedQuantum added this to the Short-Term Goals milestone Mar 5, 2025
@Argmaster
Copy link
Contributor

Argmaster commented Mar 5, 2025 •
edited
Loading

Could you elaborate on "all protocols"? Basically you mean everywhere we read and write binary data to/from buffers?

@IntegratedQuantum
Copy link
Member Author

I think it's pretty much all use cases of std.mem.readInt and std.mem.writeInt.

This was referenced Mar 5, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers refactor shuffle a lot of code around
Projects
None yet
Milestone
Short-Term Goals
Development

No branches or pull requests
2 participants
@IntegratedQuantum @Argmaster