Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ClientEntityManager.serverUpdate to use BinaryReader #1171

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Refactor ClientEntityManager.serverUpdate to use BinaryReader #1171

merged 5 commits into from
Mar 7, 2025

Conversation

Argmaster
Copy link
Contributor

@Argmaster Argmaster commented Mar 7, 2025 •
edited
Loading

This pull request:

  • Replaces raw calls to std.mem.readInt with use of BinaryReader
  • Changes treatment of corrupted/malicious payloads from crashing server to ignoring and reporting in log.

Related to: #1156

Argmaster
Argmaster commented Mar 7, 2025
View reviewed changes
Argmaster
Argmaster commented Mar 7, 2025
View reviewed changes
IntegratedQuantum
IntegratedQuantum requested changes Mar 7, 2025
View reviewed changes
IntegratedQuantum
IntegratedQuantum requested changes Mar 7, 2025
View reviewed changes
IntegratedQuantum
IntegratedQuantum approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also don't forget to update the sender-side with the writeFloat function, to make it symmetrical.

@IntegratedQuantum IntegratedQuantum merged commit 832f5e7 into PixelGuys:master Mar 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IntegratedQuantum IntegratedQuantum IntegratedQuantum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Argmaster @IntegratedQuantum