Refactor RegionFile to use BinaryReader and BinaryWriter
#1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argmaster
changed the title
RegionFile to use BinaryReaderRegionFile to use BinaryReader and BinaryWriter
IntegratedQuantum
requested changes
Mar 6, 2025
IntegratedQuantum
requested changes
Mar 6, 2025
IntegratedQuantum
approved these changes
Mar 6, 2025
|
I have checked it, twice, and honestly I am not sure. At first it was segfaulting while opening a world second time in one session, but after clean build it doesn't do that anymore, I don't see any obvious mistake in code either. |
|
Ok, then maybe try a few more times just to be sure. |
|
Did that, no reproduction anymore, I hope its for good 😝 |
|
We really should just have some CI testing :( But that's not really going to happen before #1097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1156