Rename traffic circle to roundabout #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Some languages like Esperanto will need to be updated to use the more usual word for “roundabout” instead of a literal translation of “traffic circle”: #188 (comment). But that can happen independently of this PR. |
danpaz
approved these changes
Jul 23, 2019
Contributor
danpaz
left a comment
danpaz
left a comment
There was a problem hiding this comment.
Glad we circled back on this. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The English localization now calls all circular junctions “roundabouts”. There is no longer a quaint BosWash distinction between classical roundabouts as “traffic circles” and modern roundabouts as “roundabouts” (which in practice meant roundabouts were always called “traffic circles”).
Fixes #188 and reverts #179.
Tasklist
Requirements / Relations
Same as #256, plus one year and minus the American English overrides. If an American English localization mechanism is needed in the future, we can resurrect that part of #256.
/cc @danpaz @dgearhart