Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add improvements to document template selector #712

Merged
merged 2 commits into from
May 23, 2022
Merged

Add improvements to document template selector #712

merged 2 commits into from
May 23, 2022

Conversation

Remi749
Copy link
Collaborator

@Remi749 Remi749 commented May 20, 2022

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

Improvements:

  • Sort 'Malbibliotek' view the same way as the 'Malbibliotek' library -> By name
  • Adjust max-height for the dialog to 90%
    • To hinder the dialog to go out of the windows view and instead add breathable space to bottom and top (this is for 'Malbiblotek' that has a lot of documents in it)
  • TargetFolderScreen
    • Sort TargetFolderScreen folders by name
    • Remove possibility to select multiple as this did nothing
  • Update information messages to reflect the TargetFolderScreen as the first screen doesn't say anything about selecting a target folder

How to test

  1. Open Document Template Selector and see changes metioned above

Relevant issues (if applicable)

#711

@Remi749 Remi749 self-assigned this May 20, 2022
@Remi749 Remi749 requested a review from okms as a code owner May 20, 2022 11:13
@Remi749 Remi749 added enhancement Request that will enhance the product complexity: small Issue/PR with small complexity frontend Related to frontend customer funded Issues funded by customer labels May 20, 2022
@Remi749 Remi749 added this to the 1.6.0 milestone May 20, 2022
@olemp
Copy link
Collaborator

olemp commented May 20, 2022

Resolve CHANGELOG conflict @Remi749

image

@Remi749
Copy link
Collaborator Author

Remi749 commented May 20, 2022

Resolve CHANGELOG conflict @Remi749

image

done ✔

olemp
olemp approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGIF

@Remi749 Remi749 merged commit 62471fb into dev May 23, 2022
@Remi749 Remi749 deleted the feature/doc-template-selector-improvements branch May 23, 2022 18:37
Remi749 added a commit that referenced this pull request Jun 27, 2022
@Remi749 @olemp @tarjeieo
1.6.0 prep (#738)
6dc2381 
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Remi749 added a commit that referenced this pull request Jun 27, 2022
@Remi749 @olemp @tarjeieo
v1.6.0 (#739)
a593dd5 
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

* 1.6.0

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Remi749 added a commit that referenced this pull request Jun 29, 2022
@Remi749 @olemp @tarjeieo
v1.6.1 (#746)
af74d1b 
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

* 1.6.0

* Minor update to preInstallUpgrade script

* Hotfix: Add fallback for 'projectDeliveriesListName' in timeline

* Add ViewId for views in aggregated web parts (#745)

* Add ViewId for views in aggregated web parts

* Update changelog

* 1.6.1

* v1.6.1

* Update changelog

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemp olemp olemp approved these changes

@tarjeieo tarjeieo Awaiting requested review from tarjeieo

@okms okms Awaiting requested review from okms

Assignees

@Remi749 Remi749

Labels
complexity: small Issue/PR with small complexity customer funded Issues funded by customer enhancement Request that will enhance the product frontend Related to frontend
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Remi749 @olemp